Skip to content

Added IO metrics for cgroup v2#3919

Merged
estesp merged 1 commit intocontainerd:masterfrom
Zyqsempai:add-io-metrics
Jan 17, 2020
Merged

Added IO metrics for cgroup v2#3919
estesp merged 1 commit intocontainerd:masterfrom
Zyqsempai:add-io-metrics

Conversation

@Zyqsempai
Copy link
Contributor

@Zyqsempai Zyqsempai commented Dec 23, 2019

Related to #3726

Added only Prometheus metrics for IO, since it's multi-line metrics and it can brake table in cmd metrics.

Signed-off-by: Boris Popovschi zyqsempai@mail.ru

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 23, 2019

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 23, 2019

Build succeeded.

@Zyqsempai
Copy link
Contributor Author

Zyqsempai commented Dec 24, 2019 •
edited
Loading

@AkihiroSuda @crosbymichael PTAL

@Zyqsempai
Copy link
Contributor Author

Zyqsempai commented Jan 6, 2020

@crosbymichael @AkihiroSuda ping

AkihiroSuda
AkihiroSuda reviewed Jan 7, 2020
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Jan 7, 2020
View reviewed changes
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 7, 2020

Build succeeded.

@codecov-io
Copy link

codecov-io commented Jan 7, 2020 •
edited
Loading

Codecov Report

Merging #3919 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3919      +/-   ##
==========================================
+ Coverage   42.47%   42.63%   +0.15%     
==========================================
  Files         130      130              
  Lines       14716    14759      +43     
==========================================
+ Hits         6251     6292      +41     
- Misses       7544     7548       +4     
+ Partials      921      919       -2
Flag Coverage Δ
#linux 46% <ø> (+0.13%) ⬆️
#windows 38.22% <ø> (+0.21%) ⬆️
Impacted Files Coverage Δ
mount/mount_linux.go 26.2% <0%> (-4.05%) ⬇️
metadata/snapshot.go 47.57% <0%> (-0.9%) ⬇️
runtime/v2/manager.go 4.67% <0%> (-0.09%) ⬇️
runtime/v2/binary.go 0% <0%> (ø) ⬆️
archive/tar.go 48.58% <0%> (+0.4%) ⬆️
platforms/platforms.go 80.21% <0%> (+0.87%) ⬆️
archive/tar_unix.go 43.56% <0%> (+1.14%) ⬆️
filters/parser.go 81.65% <0%> (+1.28%) ⬆️
snapshots/overlay/overlay.go 54.08% <0%> (+1.55%) ⬆️
filters/scanner.go 82.19% <0%> (+13.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97712c8...fb738c4. Read the comment docs.

@crosbymichael
Copy link
Member

crosbymichael commented Jan 8, 2020

Don't merge yet. I added some comments about major/minor metrics

@crosbymichael crosbymichael mentioned this pull request Jan 9, 2020
Closed
11 tasks
AkihiroSuda
AkihiroSuda reviewed Jan 9, 2020
View reviewed changes
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 9, 2020

Build succeeded.

@Zyqsempai
Copy link
Contributor Author

Zyqsempai commented Jan 9, 2020

@crosbymichael PTAL, do you mean something like this?

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Jan 10, 2020

We need this to be merged: containerd/cgroups#141

AkihiroSuda
AkihiroSuda reviewed Jan 13, 2020
View reviewed changes
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2020

Build succeeded.

AkihiroSuda
AkihiroSuda reviewed Jan 13, 2020
View reviewed changes
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2020

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

AkihiroSuda
AkihiroSuda approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs rebase

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Jan 13, 2020

Also, please squash commits

@Zyqsempai Zyqsempai force-pushed the add-io-metrics branch 2 times, most recently from 96e9f2f to 24e7a92 Compare January 13, 2020 19:52
@Zyqsempai
Copy link
Contributor Author

Zyqsempai commented Jan 13, 2020

Done

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2020

Build succeeded.

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Jan 14, 2020

vendor check failing

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 14, 2020

Build succeeded.

@Zyqsempai
Added IO metrics
3eb57b0 
Signed-off-by: Boris Popovschi <zyqsempai@mail.ru>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 15, 2020

Build succeeded.

@Zyqsempai
Copy link
Contributor Author

Zyqsempai commented Jan 17, 2020

@crosbymichael @estesp @AkihiroSuda Let's merge this one.

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Jan 17, 2020

@fuweid PTAL?

estesp
estesp approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 6b5553e into containerd:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crosbymichael crosbymichael crosbymichael left review comments

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zyqsempai @codecov-io @crosbymichael @AkihiroSuda @estesp