Skip to content

v2: do not parse io.stat as KV stat#141

Merged
fuweid merged 1 commit intocontainerd:masterfrom
AkihiroSuda:fix-iostat
Jan 13, 2020
Merged

v2: do not parse io.stat as KV stat#141
fuweid merged 1 commit intocontainerd:masterfrom
AkihiroSuda:fix-iostat

Conversation

@AkihiroSuda
Copy link
Member

Only cpu.stat and memory.stat should be treated as KV stat file.

Fix containerd/containerd#3951

Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp

Only `cpu.stat` and `memory.stat` should be treated as KV stat file.

Fix containerd/containerd#3951

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #141 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   33.98%   33.95%   -0.03%     
==========================================
  Files          35       35              
  Lines        2557     2559       +2     
==========================================
  Hits          869      869              
- Misses       1551     1553       +2     
  Partials      137      137
Impacted Files Coverage Δ
v2/manager.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f83850...f3f2777. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 7347743 into containerd:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cgroup2: metrics fails after a few minutes

4 participants