Skip to content

[release/1.3] cherry-pick: Fix delete error code on the containerd daemon side.#3740

Merged
crosbymichael merged 1 commit intocontainerd:release/1.3from
estesp:cp-1.3-3736
Oct 9, 2019
Merged

[release/1.3] cherry-pick: Fix delete error code on the containerd daemon side.#3740
crosbymichael merged 1 commit intocontainerd:release/1.3from
estesp:cp-1.3-3736

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Oct 9, 2019

Cherry-pick of #3736 for release/1.3

Signed-off-by: Lantao Liu lantaol@google.com
Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

Signed-off-by: Lantao Liu <lantaol@google.com>
Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 9, 2019

Build succeeded.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 9, 2019

Codecov Report

Merging #3740 into release/1.3 will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/1.3   #3740      +/-   ##
==============================================
- Coverage        45.61%   45.6%   -0.02%     
==============================================
  Files              116     116              
  Lines            11454   11458       +4     
==============================================
  Hits              5225    5225              
- Misses            5330    5334       +4     
  Partials           899     899
Flag Coverage Δ
#linux 45.6% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
runtime/v2/shim.go 1.33% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea86733...b3e9ded. Read the comment docs.

@Random-Liu
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 0b43a31 into containerd:release/1.3 Oct 9, 2019
dmcgowan pushed a commit to thaJeztah/containerd that referenced this pull request Nov 19, 2019
* Update the runc vendor to v1.0.0-rc9 which includes an additional mitigation for [CVE-2019-16884](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-16884).
    - More details on the runc CVE in [opencontainers/runc#2128](opencontainers/runc#2128), and the additional mitigations in [opencontainers/runc#2130](opencontainers/runc#2130).
* Add local-fs.target to service file to fix corrupt image after unexpected host reboot. Reported in [containerd#3671](containerd#3671), and fixed by [containerd#3745](containerd#3745).
* Fix large output of processes with TTY getting occasionally truncated. Reported in [containerd#3738](containerd#3738) and fixed by [containerd#3754](containerd#3754).
* Fix direct unpack when running in user namespace. Reported in [containerd#3762](containerd#3762), and fixed by [containerd#3779](containerd#3779).
* Update Golang runtime to 1.12.13, which includes security fixes to the `crypto/dsa` package made in Go 1.12.11 ([CVE-2019-17596](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-17596)), and fixes to the go command, `runtime`, `syscall` and `net` packages (Go 1.12.12).
* Add Windows process shim installer [containerd#3792](containerd#3792)

* CRI fixes:
    - Fix shim delete error code to avoid unnecessary retries in the CRI plugin. Discovered in [containerd/cri#1309](containerd/cri#1309), and fixed by [containerd#3733](containerd#3733) and [containerd#3740](containerd#3740).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants