Fix delete error code on the containerd daemon side.#3736
Merged
estesp merged 1 commit intocontainerd:masterfrom Oct 9, 2019
Merged
Fix delete error code on the containerd daemon side.#3736estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3736 +/- ##
==========================================
- Coverage 42.13% 42.12% -0.02%
==========================================
Files 131 131
Lines 14474 14479 +5
==========================================
Hits 6099 6099
- Misses 7467 7472 +5
Partials 908 908
Continue to review full report at Codecov.
|
Member
|
LGTM |
Member
|
I assume since #3730 was cherry picked back to 1.2 and 1.3 then we need this one as well. |
This was referenced Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With more test, I found that #3730 is not enough:
nilresponse properly.Signed-off-by: Lantao Liu lantaol@google.com