Fix shim delete error code.#3730
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Oct 8, 2019
Merged
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3730 +/- ##
==========================================
+ Coverage 42.13% 42.15% +0.01%
==========================================
Files 131 131
Lines 14474 14474
==========================================
+ Hits 6099 6101 +2
+ Misses 7467 7466 -1
+ Partials 908 907 -1
Continue to review full report at Codecov.
|
Member
|
LGTM |
This was referenced Oct 8, 2019
Contributor
|
The more I think about this I think in the future we should make this a gRPC or ttrpc interceptor that does this transform. There are other error cases in here that dont use ToGRPC and it seems pretty easy to make this mistake. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delete error code is not properly propagated.
Found this when working on containerd/cri#1309.
Let's cherrypick the fix, because the correct error code can avoid unnecessary retries in the CRI plugin.
Signed-off-by: Lantao Liu lantaol@google.com