[release/1.2 backport] Compute manifest metadata when not provided.#3591
Conversation
|
This was requested by @artch to help compatibility with the GitHub Package Registry #3245 (comment) /cc @Phanatic |
|
Looks like additional changes are needed to make this work; |
|
Need to backport #2751 |
This reverts commit 1af8e6e. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Charles Kenney <charlesc.kenney@gmail.com> (cherry picked from commit 068880f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Fixes containerd#2870 Signed-off-by: Eric Lin <linxiulei@gmail.com> (cherry picked from commit 2db0c6c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Currently the user agent is only being used on the initial resolve request, then switching to the default user agent. This ensures the correct user agent is always used. There is a larger fix in progress which does this is a cleaner way, but the scope of this change is fixing the user agent issue. Signed-off-by: Derek McGowan <derek@mcgstyle.net> (cherry picked from commit bb00872) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This closes containerd#3238 Signed-off-by: msg555 <msg555@gmail.com> (cherry picked from commit ee902af) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
0a49e64 to
0d6d883
Compare
|
OK; I had a look what is needed to get a clean backport, but that would include #3335, which (I think) is a feature.
I'll leave it to the maintainers to decide if this is ok, or if I need to spend some time to adapt the backport to work |
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3591 +/- ##
===============================================
- Coverage 44.09% 44.03% -0.07%
===============================================
Files 100 100
Lines 10790 10837 +47
===============================================
+ Hits 4758 4772 +14
- Misses 5293 5325 +32
- Partials 739 740 +1
Continue to review full report at Codecov.
|
backport of #3245 for the 1.2 branch
Adds a fallback to manually compute the manifest digest when it is not presented as the Docker-Content-Digest header by the registry server. This is to address #3238.
closes #3238
addresses parts of #3291