Skip to content

Add custom headers resolver option#2751

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
0xch4z:add-useragent-resolver-option
Nov 20, 2018
Merged

Add custom headers resolver option#2751
dmcgowan merged 1 commit intocontainerd:masterfrom
0xch4z:add-useragent-resolver-option

Conversation

@0xch4z
Copy link
Contributor

@0xch4z 0xch4z commented Oct 30, 2018

Resolves #2719.

@0xch4z 0xch4z force-pushed the add-useragent-resolver-option branch 2 times, most recently from 9ee4c3d to edde885 Compare October 30, 2018 17:52
@codecov-io
Copy link

codecov-io commented Oct 30, 2018 •
edited
Loading

Codecov Report

Merging #2751 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2751      +/-   ##
==========================================
+ Coverage   43.72%   43.77%   +0.05%     
==========================================
  Files         100      100              
  Lines       10734    10745      +11     
==========================================
+ Hits         4693     4704      +11     
  Misses       5311     5311              
  Partials      730      730
Flag Coverage Δ
#linux 47.43% <100%> (+0.04%) ⬆️
#windows 40.96% <100%> (+0.06%) ⬆️
Impacted Files Coverage Δ
remotes/docker/resolver.go 60.15% <100%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b043f9f...068880f. Read the comment docs.

dmcgowan
dmcgowan reviewed Oct 30, 2018
View reviewed changes
@0xch4z 0xch4z force-pushed the add-useragent-resolver-option branch from edde885 to 9dc3ae9 Compare October 31, 2018 14:54
@0xch4z 0xch4z changed the title Add UserAgent resolver option Add custom headers resolver option Oct 31, 2018
estesp
estesp approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I think the Accept header could be part of the new generic headers map; but willing to see if @dmcgowan thinks that is useful as well.

dmcgowan
dmcgowan reviewed Oct 31, 2018
View reviewed changes
@0xch4z 0xch4z force-pushed the add-useragent-resolver-option branch from 9dc3ae9 to b0649ec Compare October 31, 2018 23:32
@0xch4z
Add custom headers option to dockerResolver
068880f 
Signed-off-by: Charles Kenney <charlesc.kenney@gmail.com>
@0xch4z 0xch4z force-pushed the add-useragent-resolver-option branch from b0649ec to 068880f Compare October 31, 2018 23:43
estesp
estesp approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan
Copy link
Member

dmcgowan commented Nov 20, 2018

LGTM

@dmcgowan dmcgowan merged commit b8631c7 into containerd:master Nov 20, 2018
@thaJeztah thaJeztah mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan left review comments

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xch4z @codecov-io @dmcgowan @estesp