Skip to content

Explicitly stating utf-8 when fetching oauth token#2871

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
linxiulei:fix_oauth_utf8
Dec 13, 2018
Merged

Explicitly stating utf-8 when fetching oauth token#2871
crosbymichael merged 1 commit intocontainerd:masterfrom
linxiulei:fix_oauth_utf8

Conversation

@linxiulei
Copy link
Contributor

Fixes #2870

Signed-off-by: Eric Lin linxiulei@gmail.com

Fixes containerd#2870

Signed-off-by: Eric Lin <linxiulei@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #2871 into master will increase coverage by 2.79%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2871      +/-   ##
==========================================
+ Coverage   41.04%   43.84%   +2.79%     
==========================================
  Files          70      101      +31     
  Lines        9445    10800    +1355     
==========================================
+ Hits         3877     4735     +858     
- Misses       5010     5334     +324     
- Partials      558      731     +173
Flag Coverage Δ
#linux 47.43% <100%> (?)
#windows 41.07% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
remotes/docker/authorizer.go 68.2% <100%> (+0.66%) ⬆️
mount/temp_unix.go 0% <0%> (ø)
sys/reaper_linux.go 0% <0%> (ø)
services/server/server_linux.go 0% <0%> (ø)
sys/env.go 100% <0%> (ø)
sys/stat_unix.go 0% <0%> (ø)
runtime/v2/shim/shim_unix.go 0% <0%> (ø)
sys/reaper.go 0% <0%> (ø)
sys/fds.go 0% <0%> (ø)
runtime/v2/shim/reaper_unix.go 0% <0%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ccff37...2db0c6c. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #2871 into master will increase coverage by 2.79%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2871      +/-   ##
==========================================
+ Coverage   41.04%   43.84%   +2.79%     
==========================================
  Files          70      101      +31     
  Lines        9445    10800    +1355     
==========================================
+ Hits         3877     4735     +858     
- Misses       5010     5334     +324     
- Partials      558      731     +173
Flag Coverage Δ
#linux 47.43% <100%> (?)
#windows 41.07% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
remotes/docker/authorizer.go 68.2% <100%> (+0.66%) ⬆️
mount/temp_unix.go 0% <0%> (ø)
sys/reaper_linux.go 0% <0%> (ø)
services/server/server_linux.go 0% <0%> (ø)
sys/env.go 100% <0%> (ø)
sys/stat_unix.go 0% <0%> (ø)
runtime/v2/shim/shim_unix.go 0% <0%> (ø)
sys/reaper.go 0% <0%> (ø)
sys/fds.go 0% <0%> (ø)
runtime/v2/shim/reaper_unix.go 0% <0%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ccff37...2db0c6c. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants