Partially revert the event discard change in #2748.#2770
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Nov 9, 2018
Merged
Partially revert the event discard change in #2748.#2770crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
Member
Author
Member
|
Took me a second, but now I get what you are saying--we have branched |
Codecov Report
@@ Coverage Diff @@
## master #2770 +/- ##
=======================================
Coverage 43.72% 43.72%
=======================================
Files 100 100
Lines 10734 10734
=======================================
Hits 4693 4693
Misses 5311 5311
Partials 730 730
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion at #2762 (comment), we decided not to discard events, because it breaks the assumption that client can rely on
TaskExitevents to detect container stop.If
TaskExitevents can be discarded, the client has to do periodically state check, which is not ideal.Signed-off-by: Lantao Liu lantaol@google.com