[release/1.1] cherry-pick: optimize shim lock in runtime v1#2765
Merged
estesp merged 1 commit intocontainerd:release/1.1from Nov 6, 2018
Merged
Conversation
apply lock only around process map of shim service, avoid lock affect other procs operations. Signed-off-by: Ace-Tang <aceapril@126.com>
Codecov Report
@@ Coverage Diff @@
## release/1.1 #2765 +/- ##
============================================
Coverage 48.99% 48.99%
============================================
Files 85 85
Lines 7603 7603
============================================
Hits 3725 3725
Misses 3203 3203
Partials 675 675
Continue to review full report at Codecov.
|
Member
|
LGTM |
This was referenced Nov 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also need this fix in release 1.1.
I think this is the last piece for #2709.
Note that the lock location for
Createis not updated in this cherry-pick, because:Createshould be called as the first function, and no other functions will be called at the same time.release/1.1, all logic is inproc.New. There is no way for us to add the lock at the same place with bugfix: optimize shim lock in runtime v1 avoid dead lock #2743./cc @Ace-Tang