Increase reaper buffer size and non-blocking send#2748
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Oct 29, 2018
Merged
Increase reaper buffer size and non-blocking send#2748crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Member
|
what about v2 reaper? |
Member
Author
|
@estesp good catch |
Fixes containerd#2709 This increases the buffer size for process exit subscribers. It also implements a non-blocking send on the subscriber channel. It is better to drop an exit even than it is to block a shim for one slow subscriber. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
92009c5 to
232a063
Compare
Codecov Report
@@ Coverage Diff @@
## master #2748 +/- ##
==========================================
- Coverage 47.41% 43.73% -3.68%
==========================================
Files 91 100 +9
Lines 8411 10730 +2319
==========================================
+ Hits 3988 4693 +705
- Misses 3700 5307 +1607
- Partials 723 730 +7
Continue to review full report at Codecov.
|
mlaventure
approved these changes
Oct 29, 2018
Random-Liu
added a commit
to Random-Liu/containerd
that referenced
this pull request
Nov 8, 2018
Signed-off-by: Lantao Liu <lantaol@google.com>
crosbymichael
added a commit
that referenced
this pull request
Nov 9, 2018
Partially revert the event discard change in #2748.
estesp
pushed a commit
to estesp/containerd
that referenced
this pull request
Nov 11, 2018
Signed-off-by: Lantao Liu <lantaol@google.com> Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
estesp
pushed a commit
to estesp/containerd
that referenced
this pull request
Nov 16, 2018
Signed-off-by: Lantao Liu <lantaol@google.com> Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
crosbymichael
added a commit
to crosbymichael/containerd
that referenced
this pull request
Nov 16, 2018
Partial revert of containerd#2748 Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
estesp
pushed a commit
to estesp/containerd
that referenced
this pull request
Nov 17, 2018
Partial revert of containerd#2748 Signed-off-by: Michael Crosby <crosbymichael@gmail.com> Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2709
This increases the buffer size for process exit subscribers. It also
implements a non-blocking send on the subscriber channel. It is better
to drop an exit even than it is to block a shim for one slow subscriber.
Signed-off-by: Michael Crosby crosbymichael@gmail.com