update to github.com/sirupsen/logrus v1.0.0 [carry #1136]#1234
Merged
stevvooe merged 2 commits intocontainerd:masterfrom Jul 21, 2017
Merged
update to github.com/sirupsen/logrus v1.0.0 [carry #1136]#1234stevvooe merged 2 commits intocontainerd:masterfrom
stevvooe merged 2 commits intocontainerd:masterfrom
Conversation
Signed-off-by: Andrew Pennebaker <apennebaker@datapipe.com>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Codecov Report
@@ Coverage Diff @@
## master #1234 +/- ##
=======================================
Coverage 27.91% 27.91%
=======================================
Files 28 28
Lines 2826 2826
=======================================
Hits 789 789
Misses 1888 1888
Partials 149 149
Continue to review full report at Codecov.
|
Member
|
LGTM |
ianlewis
pushed a commit
to ianlewis/containerd
that referenced
this pull request
Dec 8, 2020
…to-fix-race Update containerd to fix panic caused by race condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Carry #1136 for upstream changes]
Pending microsoft/hcsshim#136
Fix some dependencies by updating casing to github.com/sirupsen/logrus (The project has moved.)
go test still fails with plugin/context.go:8:2: case-insensitive import collision. Likely need to fix the logrus casing in containerd's dependencies' code as well.