update to github.com/sirupsen/logrus v1.0.0#1136
Closed
mcandre wants to merge 1 commit intocontainerd:masterfrom
mcandre:update-logrus
Closed
update to github.com/sirupsen/logrus v1.0.0#1136mcandre wants to merge 1 commit intocontainerd:masterfrom mcandre:update-logrus
mcandre wants to merge 1 commit intocontainerd:masterfrom
mcandre:update-logrus
Conversation
Signed-off-by: Andrew Pennebaker <apennebaker@datapipe.com>
Codecov Report
@@ Coverage Diff @@
## master #1136 +/- ##
=======================================
Coverage 31.69% 31.69%
=======================================
Files 27 27
Lines 2174 2174
=======================================
Hits 689 689
Misses 1337 1337
Partials 148 148
Continue to review full report at Codecov.
|
Member
|
LGTM Thanks @mcandre |
Member
|
LGTM |
Member
|
Does continuity need to be merged first? |
Member
Contributor
|
Are we certain the decision is not going to be reverted again? |
Member
|
Right now runc is failing with this change so we can hold off until that downstream is resolved. |
Member
|
@mlaventure Roll forward, not back! |
Member
|
Can you please update this, some of the downstreams have merged their changes |
Member
|
Carrying in #1234 |
stevvooe
added a commit
that referenced
this pull request
Jul 21, 2017
update to github.com/sirupsen/logrus v1.0.0 [carry #1136]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Pennebaker apennebaker@datapipe.com
Fix some dependencies by updating casing to github.com/sirupsen/logrus (The project has moved.)
go teststill fails withplugin/context.go:8:2: case-insensitive import collision. Likely need to fix the logrus casing in containerd's dependencies' code as well.