Move to go modules#18
Merged
fuweid merged 3 commits intocontainerd:masterfrom Jan 6, 2020
chenrui333:go-modules
Merged
Conversation
Contributor
Author
|
Member
|
should be consistent with containerd/zfs#26 |
16 tasks
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Contributor
Author
|
@AkihiroSuda FYI, I will spend more time on this later today or tomorrow. :) |
AkihiroSuda
reviewed
Jan 6, 2020
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 56.01% 1.65% -54.36%
==========================================
Files 1 1
Lines 241 241
==========================================
- Hits 135 4 -131
- Misses 72 236 +164
+ Partials 34 1 -33
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Jan 6, 2020
AkihiroSuda
reviewed
Jan 6, 2020
| - ../project/script/validate/fileheader ../project/ | ||
| - go test -race -covermode=atomic -c | ||
| - sudo ./aufs.test -test.root -test.v -test.coverprofile=coverage.txt | ||
| - go test -v -race -covermode=atomic -coverprofile=coverage.txt ./... |
Member
There was a problem hiding this comment.
this part broke the CI, @chenrui333 could you revert this part?
=== RUN TestAufs
--- SKIP: TestAufs (0.00s)
helpers_unix.go:41: skipping test that requires root
Contributor
Author
There was a problem hiding this comment.
Got it, I will fix it now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracker, containerd/containerd#3031