Merged
Conversation
16 tasks
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 55.68% 55.68%
=======================================
Files 1 1
Lines 176 176
=======================================
Hits 98 98
Misses 51 51
Partials 27 27Continue to review full report at Codecov.
|
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This was referenced Dec 14, 2019
Closed
fuweid
reviewed
Dec 19, 2019
| - cd $GOPATH/src/github.com/containerd/zfs | ||
| - go get -t ./... | ||
| - GO111MODULE="on" go mod vendor | ||
| - go get -u github.com/vbatts/git-validation |
Member
There was a problem hiding this comment.
after we add vendor check, we cannot call get get in module because it will change existing file. will change it in followup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of containerd/containerd#3031