Fix skipping test that requires root issue#19
Fix skipping test that requires root issue#19chenrui333 wants to merge 2 commits intocontainerd:masterfrom chenrui333:fix-go-test-issue
skipping test that requires root issue#19Conversation
|
ping @chenrui333 |
|
Thanks the reminder, picking it up now. |
|
CI still failing. maybe |
|
Also, don't drop |
|
I am going to spin up a new repo and test it separately. |
|
Looks like travis does not have debug mode by default for public repo, I have to switch to company private repo to debug the build. |
|
@fuweid @AkihiroSuda should be good now, thanks for the help! |
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
===========================================
+ Coverage 1.65% 56.01% +54.35%
===========================================
Files 1 1
Lines 241 241
===========================================
+ Hits 4 135 +131
+ Misses 236 72 -164
- Partials 1 34 +33
Continue to review full report at Codecov.
|
| - DCO_VERBOSITY=-q ../project/script/validate/dco | ||
| - ../project/script/validate/fileheader ../project/ | ||
| - go test -v -race -covermode=atomic -coverprofile=coverage.txt ./... | ||
| - sudo $GOROOT/bin/go test -test.root -test.v -race -covermode=atomic -coverprofile=coverage.txt ./... |
There was a problem hiding this comment.
Tried to use export PATH=$GOROOT/bin:$PATH, seems not quite work out. Let me know if you guys prefer to have a comment for this line as well.
There was a problem hiding this comment.
travis@travis-job-f1c1eeb9-d213-4c5b-bd66-aa15232af65a:~/gopath/src/github.com/meetup/aufs-test$ export PATH=$GOROOT/bin:$PATH
travis@travis-job-f1c1eeb9-d213-4c5b-bd66-aa15232af65a:~/gopath/src/github.com/meetup/aufs-test$ sudo go test -test.root -test.v -race -covermode=atomic -coverprofile=coverage.txt ./...
sudo: go: command not found
There was a problem hiding this comment.
Why not simply use go test -c as in former revisions?
There was a problem hiding this comment.
I thought we have sudo: go: command not found issue?
There was a problem hiding this comment.
So previous version didn't have that issue because we don't need sudo go for go test -c
Signed-off-by: Rui Chen <chenrui333@gmail.com>
|
ping @chenrui333 |
|
We are switching away from Travis (#25), so closing this |
Relates to containerd/zfs@220e87a