Remove `golang.org/x/net/http2` dependency from tests by maxbrunet · Pull Request #877 · connectrpc/connect-go

maxbrunet · 2025-09-11T15:41:57Z

Follow up to #873

Replace golang.org/x/net/http2 by the standard net/http module for both clients and servers in all tests

The std lib implementation being more polished, it caught a few bugs like streams never closed

Signed-off-by: Maxime Brunet <max@brnt.mx>

jhump · 2025-09-22T19:14:12Z

@maxbrunet, I updated this branch to latest main (which is a requirement for merging PRs in this repo), but now a test is failing (seems to be somewhat consistent since it failed in the same way in two CI jobs).

It admittedly doesn't look related to your changes, but master is green and this branch is not. Maybe it's a semantic merge conflict about an error condition that doesn't harmonize with your changes to memhttp or the fact that TLS is no longer being used? Let me know if you get a chance to investigate and conclude that something else is to blame other than your changes in this PR.

Signed-off-by: Edward McFarlane <emcfarlane@buf.build>

emcfarlane · 2025-09-23T20:59:07Z

internal/memhttp/memhttp.go

+
+	transport := s.TransportHTTP1()
+	transport.Protocols = protocols
+	transport.DisableKeepAlives = false


@maxbrunet This changed from the previous configuration so I've just gone through and disabled it. Fixed the test case which can be reproduced by running:

$ go test -race -run=TestGRPCMissingTrailersError/cumsum . --count=10 --- FAIL: TestGRPCMissingTrailersError (0.00s) --- FAIL: TestGRPCMissingTrailersError/cumsum (0.00s) connect_ext_test.go:1194: assertion: assert.Equal got: unavailable want: unknown connect_ext_test.go:1194: assertion: assert.True got: false

The hidden error message is: net/http: cannot rewind body after connection loss.

I have a TODO below to enable keep alives for TransportHTTP1 but will need to do this cleanup in another PR.

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [connectrpc.com/connect](https://github.com/connectrpc/connect-go) | `v1.18.1` -> `v1.19.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/connectrpc.com%2fconnect/v1.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/connectrpc.com%2fconnect/v1.18.1/v1.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>connectrpc/connect-go (connectrpc.com/connect)</summary> ### [`v1.19.0`](https://github.com/connectrpc/connect-go/releases/tag/v1.19.0) [Compare Source](connectrpc/connect-go@v1.18.1...v1.19.0) This release introduces the highly requested "simple" flag for code generation, making Connect significantly more ergonomic for everyday RPC development. The new simple flag in protoc-gen-connect-go generates cleaner, more intuitive client and handler interfaces that eliminate request/response wrappers for most use cases. This addresses community feedback about verbosity and provides a more straightforward API. When enabled, metadata (headers/trailers) can be passed through context instead of explicit wrapper objects, optimizing for the common case where developers don't need direct access to HTTP headers. #### What's Changed ##### Enhancements - Add simple flag for more ergonomic generated code by [@bufdev](https://github.com/bufdev) and [@smaye81](https://github.com/smaye81) in [#851](connectrpc/connect-go#851) - Update Go to v1.24 and document http.Protocol use removing the dependency on `golang.org/x/net/http2` by [@maxbrunet](https://github.com/maxbrunet) in [#873](connectrpc/connect-go#873), [#877](connectrpc/connect-go#877) - Add support for Edition 2024 by [@emcfarlane](https://github.com/emcfarlane) in [#878](connectrpc/connect-go#878) ##### Bugfixes - Include valid spec and headers when calling recover handler for streaming RPCs by [@jhump](https://github.com/jhump) in [#817](connectrpc/connect-go#817) ##### Other changes - Go version support updated to latest two instead of three by [@jhump](https://github.com/jhump) in [#837](connectrpc/connect-go#837) - CI testing improvements by [@pkwarren](https://github.com/pkwarren) and [@jhump](https://github.com/jhump) in [#838](connectrpc/connect-go#838), [#839](connectrpc/connect-go#839) - Code quality improvements by [@mattrobenolt](https://github.com/mattrobenolt) and [@bufdev](https://github.com/bufdev) in [#841](connectrpc/connect-go#841), [#867](connectrpc/connect-go#867) - Documentation improvements by [@adlion](https://github.com/adlion) and [@stefanvanburen](https://github.com/stefanvanburen) in [#821](connectrpc/connect-go#821), [#880](connectrpc/connect-go#880) #### New Contributors - [@adlion](https://github.com/adlion) made their first contribution in [#821](connectrpc/connect-go#821) - [@maxbrunet](https://github.com/maxbrunet) made their first contribution in [#873](connectrpc/connect-go#873) - [@stefanvanburen](https://github.com/stefanvanburen) made their first contribution in [#880](connectrpc/connect-go#880) **Full Changelog**: <connectrpc/connect-go@v1.18.1...v1.19.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Earl Warren <contact@earl-warren.org> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9425 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [connectrpc.com/connect](https://github.com/connectrpc/connect-go) | `v1.18.1` -> `v1.19.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/connectrpc.com%2fconnect/v1.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/connectrpc.com%2fconnect/v1.18.1/v1.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>connectrpc/connect-go (connectrpc.com/connect)</summary> ### [`v1.19.0`](https://github.com/connectrpc/connect-go/releases/tag/v1.19.0) [Compare Source](connectrpc/connect-go@v1.18.1...v1.19.0) This release introduces the highly requested "simple" flag for code generation, making Connect significantly more ergonomic for everyday RPC development. The new simple flag in protoc-gen-connect-go generates cleaner, more intuitive client and handler interfaces that eliminate request/response wrappers for most use cases. This addresses community feedback about verbosity and provides a more straightforward API. When enabled, metadata (headers/trailers) can be passed through context instead of explicit wrapper objects, optimizing for the common case where developers don't need direct access to HTTP headers. #### What's Changed ##### Enhancements - Add simple flag for more ergonomic generated code by [@bufdev](https://github.com/bufdev) and [@smaye81](https://github.com/smaye81) in [#851](connectrpc/connect-go#851) - Update Go to v1.24 and document http.Protocol use removing the dependency on `golang.org/x/net/http2` by [@maxbrunet](https://github.com/maxbrunet) in [#873](connectrpc/connect-go#873), [#877](connectrpc/connect-go#877) - Add support for Edition 2024 by [@emcfarlane](https://github.com/emcfarlane) in [#878](connectrpc/connect-go#878) ##### Bugfixes - Include valid spec and headers when calling recover handler for streaming RPCs by [@jhump](https://github.com/jhump) in [#817](connectrpc/connect-go#817) ##### Other changes - Go version support updated to latest two instead of three by [@jhump](https://github.com/jhump) in [#837](connectrpc/connect-go#837) - CI testing improvements by [@pkwarren](https://github.com/pkwarren) and [@jhump](https://github.com/jhump) in [#838](connectrpc/connect-go#838), [#839](connectrpc/connect-go#839) - Code quality improvements by [@mattrobenolt](https://github.com/mattrobenolt) and [@bufdev](https://github.com/bufdev) in [#841](connectrpc/connect-go#841), [#867](connectrpc/connect-go#867) - Documentation improvements by [@adlion](https://github.com/adlion) and [@stefanvanburen](https://github.com/stefanvanburen) in [#821](connectrpc/connect-go#821), [#880](connectrpc/connect-go#880) #### New Contributors - [@adlion](https://github.com/adlion) made their first contribution in [#821](connectrpc/connect-go#821) - [@maxbrunet](https://github.com/maxbrunet) made their first contribution in [#873](connectrpc/connect-go#873) - [@stefanvanburen](https://github.com/stefanvanburen) made their first contribution in [#880](connectrpc/connect-go#880) **Full Changelog**: <connectrpc/connect-go@v1.18.1...v1.19.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1029 Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org> Co-authored-by: Renovate Bot <bot@kriese.eu> Co-committed-by: Renovate Bot <bot@kriese.eu>

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [connectrpc.com/connect](https://github.com/connectrpc/connect-go) | `v1.18.1` -> `v1.19.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/connectrpc.com%2fconnect/v1.19.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/connectrpc.com%2fconnect/v1.18.1/v1.19.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>connectrpc/connect-go (connectrpc.com/connect)</summary> ### [`v1.19.1`](https://github.com/connectrpc/connect-go/releases/tag/v1.19.1) [Compare Source](connectrpc/connect-go@v1.19.0...v1.19.1)  #### What's Changed ##### Bugfixes - Fix bounds check on envelope for 32-bit archs by [@emcfarlane](https://github.com/emcfarlane) in [#887](connectrpc/connect-go#887) - Fix CallInfo header/trailer propagation on error responses by [@emcfarlane](https://github.com/emcfarlane) in [#892](connectrpc/connect-go#892) **Full Changelog**: <connectrpc/connect-go@v1.19.0...v1.19.1> ### [`v1.19.0`](https://github.com/connectrpc/connect-go/releases/tag/v1.19.0) [Compare Source](connectrpc/connect-go@v1.18.1...v1.19.0) This release introduces the highly requested "simple" flag for code generation, making Connect significantly more ergonomic for everyday RPC development. The new simple flag in protoc-gen-connect-go generates cleaner, more intuitive client and handler interfaces that eliminate request/response wrappers for most use cases. This addresses community feedback about verbosity and provides a more straightforward API. When enabled, metadata (headers/trailers) can be passed through context instead of explicit wrapper objects, optimizing for the common case where developers don't need direct access to HTTP headers. #### What's Changed ##### Enhancements - Add simple flag for more ergonomic generated code by [@bufdev](https://github.com/bufdev) and [@smaye81](https://github.com/smaye81) in [#851](connectrpc/connect-go#851) - Update Go to v1.24 and document http.Protocol use removing the dependency on `golang.org/x/net/http2` by [@maxbrunet](https://github.com/maxbrunet) in [#873](connectrpc/connect-go#873), [#877](connectrpc/connect-go#877) - Add support for Edition 2024 by [@emcfarlane](https://github.com/emcfarlane) in [#878](connectrpc/connect-go#878) ##### Bugfixes - Include valid spec and headers when calling recover handler for streaming RPCs by [@jhump](https://github.com/jhump) in [#817](connectrpc/connect-go#817) ##### Other changes - Go version support updated to latest two instead of three by [@jhump](https://github.com/jhump) in [#837](connectrpc/connect-go#837) - CI testing improvements by [@pkwarren](https://github.com/pkwarren) and [@jhump](https://github.com/jhump) in [#838](connectrpc/connect-go#838), [#839](connectrpc/connect-go#839) - Code quality improvements by [@mattrobenolt](https://github.com/mattrobenolt) and [@bufdev](https://github.com/bufdev) in [#841](connectrpc/connect-go#841), [#867](connectrpc/connect-go#867) - Documentation improvements by [@adlion](https://github.com/adlion) and [@stefanvanburen](https://github.com/stefanvanburen) in [#821](connectrpc/connect-go#821), [#880](connectrpc/connect-go#880) #### New Contributors - [@adlion](https://github.com/adlion) made their first contribution in [#821](connectrpc/connect-go#821) - [@maxbrunet](https://github.com/maxbrunet) made their first contribution in [#873](connectrpc/connect-go#873) - [@stefanvanburen](https://github.com/stefanvanburen) made their first contribution in [#880](connectrpc/connect-go#880) **Full Changelog**: <connectrpc/connect-go@v1.18.1...v1.19.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1078 Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org> Co-authored-by: Renovate Bot <bot@kriese.eu> Co-committed-by: Renovate Bot <bot@kriese.eu>

maxbrunet force-pushed the test/h2c-std-lib branch 2 times, most recently from df42f97 to fda99e1 Compare September 11, 2025 15:46

maxbrunet changed the title ~~test: remove golang.org/x/net/http2 dependency~~ Remove golang.org/x/net/http2 dependency from tests Sep 11, 2025

maxbrunet force-pushed the test/h2c-std-lib branch from fda99e1 to 9cf7660 Compare September 11, 2025 15:55

Remove golang.org/x/net/http2 dependency from tests

cbc5d68

Signed-off-by: Maxime Brunet <max@brnt.mx>

maxbrunet force-pushed the test/h2c-std-lib branch from 9cf7660 to cbc5d68 Compare September 14, 2025 14:05

jhump approved these changes Sep 22, 2025

View reviewed changes

jhump enabled auto-merge (squash) September 22, 2025 19:05

Merge branch 'main' into test/h2c-std-lib

4025914

Enable keep alives for memhttp transport

8c3a44f

Signed-off-by: Edward McFarlane <emcfarlane@buf.build>

emcfarlane approved these changes Sep 23, 2025

View reviewed changes

emcfarlane disabled auto-merge September 23, 2025 21:00

jhump merged commit cf078a1 into connectrpc:main Sep 24, 2025
9 checks passed

emcfarlane mentioned this pull request Sep 24, 2025

Prepare for v1.19.0 #883

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `golang.org/x/net/http2` dependency from tests#877

Remove `golang.org/x/net/http2` dependency from tests#877
jhump merged 3 commits intoconnectrpc:mainfrom
maxbrunet:test/h2c-std-lib

maxbrunet commented Sep 11, 2025 •

edited

Loading

Uh oh!

jhump commented Sep 22, 2025

Uh oh!

emcfarlane Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

maxbrunet commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhump commented Sep 22, 2025

Uh oh!

emcfarlane Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maxbrunet commented Sep 11, 2025 •

edited

Loading