Support latest two versions of Go instead of latest three by jhump · Pull Request #837 · connectrpc/connect-go

jhump · 2025-03-19T16:54:52Z

This changes the support posture for Go runtimes to mirror the Go SDK itself and to also mirror recent changes in the Google Cloud APIs for Go (starting January 1st, 2025).

The AWS APIs for Go still maintain support for three versions of Go, but they do have a caveat:

AWS reserves the right to drop support for unsupported Go versions earlier to address critical security issues.

This caveat is topical because the reason I'm proposing changing to supporting only two versions is spurred by a security fix: v0.36.0 of golang.org/x/net requires Go 1.23.

I'm opening this PR to gather feedback:

What do other maintainers think of this change?
If we deem this change appropriate, is there anything else we should do to communicate the change to users?
Should we instead take a softer stance, a la the AWS support policy? (In this case, we'd still document support for three versions, but we could technically go ahead and merge the above fix and temporarily only support two versions.)

The impact of this change is fairly broad and will also end up requiring a similar change to seven other Go repos in the connectrpc organization, since they all depend on this one (basically all but otelconnect-go, which already is documented as supporting only two versions of Go).

Signed-off-by: Josh Humphries <2035234+jhump@users.noreply.github.com>

mattrobenolt · 2025-03-19T20:50:42Z

I personally think this is reasonable, this is no issue for us, we try to maintain 1 version behind latest at most, we have a lot of services running 1.23.x still, but nothing older.

akshayjshah

I'm very much in favor of this change - let's do it!

To make future maintenance easier, why not use the "stable" and "oldstable" aliases instead of explicitly pinning particular Go releases? With the aliases, we won't need to do this biannual cross-repo chore.

…he set of required checks when we change Go versions Signed-off-by: Josh Humphries <2035234+jhump@users.noreply.github.com>

jhump · 2025-03-24T19:02:15Z

To make future maintenance easier, why not use the "stable" and "oldstable" aliases instead of explicitly pinning particular Go releases? With the aliases, we won't need to do this biannual cross-repo chore.

@emcfarlane, @nicksnyder, and I discussed this. One issue is that there are actually nearly always breakages when we upgrade a version of Go -- not from the new Go version itself but from golangci-lint. The new version of Go frequently has stuff in it (like in stdlib object files or code) that older versions of golangci-lint don't understand and/or don't like. So frequently we have to update the linter when we update Go versions. And updating the linter is always its own chore because new versions pretty much always include new linters that catch things in the code that we should revise/improve.

So we could use these labels, but we'd then need a nightly job so that we can be notified of red CI automatically when a new version becomes stable, instead of waiting for the first PR thereafter. And if we do this, main will be red for some period of time until we get the linter updated (which may have its own lag time between the Go release and the updated version of golangci-lint being releated) and the codebase back to green.

We decided maybe it's better to upgrade Go manually instead of having main be red for some window after a new Go version is released. So the latest commit I pushed still uses explicit Go versions, but it changes the CI job names to not include the Go version -- that way, we at least don't need to worry about adding/removing required checks when updating to the latest version of Go.

Signed-off-by: Josh Humphries <2035234+jhump@users.noreply.github.com>

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [connectrpc.com/connect](https://github.com/connectrpc/connect-go) | `v1.18.1` -> `v1.19.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/connectrpc.com%2fconnect/v1.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/connectrpc.com%2fconnect/v1.18.1/v1.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>connectrpc/connect-go (connectrpc.com/connect)</summary> ### [`v1.19.0`](https://github.com/connectrpc/connect-go/releases/tag/v1.19.0) [Compare Source](connectrpc/connect-go@v1.18.1...v1.19.0) This release introduces the highly requested "simple" flag for code generation, making Connect significantly more ergonomic for everyday RPC development. The new simple flag in protoc-gen-connect-go generates cleaner, more intuitive client and handler interfaces that eliminate request/response wrappers for most use cases. This addresses community feedback about verbosity and provides a more straightforward API. When enabled, metadata (headers/trailers) can be passed through context instead of explicit wrapper objects, optimizing for the common case where developers don't need direct access to HTTP headers. #### What's Changed ##### Enhancements - Add simple flag for more ergonomic generated code by [@bufdev](https://github.com/bufdev) and [@smaye81](https://github.com/smaye81) in [#851](connectrpc/connect-go#851) - Update Go to v1.24 and document http.Protocol use removing the dependency on `golang.org/x/net/http2` by [@maxbrunet](https://github.com/maxbrunet) in [#873](connectrpc/connect-go#873), [#877](connectrpc/connect-go#877) - Add support for Edition 2024 by [@emcfarlane](https://github.com/emcfarlane) in [#878](connectrpc/connect-go#878) ##### Bugfixes - Include valid spec and headers when calling recover handler for streaming RPCs by [@jhump](https://github.com/jhump) in [#817](connectrpc/connect-go#817) ##### Other changes - Go version support updated to latest two instead of three by [@jhump](https://github.com/jhump) in [#837](connectrpc/connect-go#837) - CI testing improvements by [@pkwarren](https://github.com/pkwarren) and [@jhump](https://github.com/jhump) in [#838](connectrpc/connect-go#838), [#839](connectrpc/connect-go#839) - Code quality improvements by [@mattrobenolt](https://github.com/mattrobenolt) and [@bufdev](https://github.com/bufdev) in [#841](connectrpc/connect-go#841), [#867](connectrpc/connect-go#867) - Documentation improvements by [@adlion](https://github.com/adlion) and [@stefanvanburen](https://github.com/stefanvanburen) in [#821](connectrpc/connect-go#821), [#880](connectrpc/connect-go#880) #### New Contributors - [@adlion](https://github.com/adlion) made their first contribution in [#821](connectrpc/connect-go#821) - [@maxbrunet](https://github.com/maxbrunet) made their first contribution in [#873](connectrpc/connect-go#873) - [@stefanvanburen](https://github.com/stefanvanburen) made their first contribution in [#880](connectrpc/connect-go#880) **Full Changelog**: <connectrpc/connect-go@v1.18.1...v1.19.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Earl Warren <contact@earl-warren.org> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9425 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [connectrpc.com/connect](https://github.com/connectrpc/connect-go) | `v1.18.1` -> `v1.19.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/connectrpc.com%2fconnect/v1.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/connectrpc.com%2fconnect/v1.18.1/v1.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>connectrpc/connect-go (connectrpc.com/connect)</summary> ### [`v1.19.0`](https://github.com/connectrpc/connect-go/releases/tag/v1.19.0) [Compare Source](connectrpc/connect-go@v1.18.1...v1.19.0) This release introduces the highly requested "simple" flag for code generation, making Connect significantly more ergonomic for everyday RPC development. The new simple flag in protoc-gen-connect-go generates cleaner, more intuitive client and handler interfaces that eliminate request/response wrappers for most use cases. This addresses community feedback about verbosity and provides a more straightforward API. When enabled, metadata (headers/trailers) can be passed through context instead of explicit wrapper objects, optimizing for the common case where developers don't need direct access to HTTP headers. #### What's Changed ##### Enhancements - Add simple flag for more ergonomic generated code by [@bufdev](https://github.com/bufdev) and [@smaye81](https://github.com/smaye81) in [#851](connectrpc/connect-go#851) - Update Go to v1.24 and document http.Protocol use removing the dependency on `golang.org/x/net/http2` by [@maxbrunet](https://github.com/maxbrunet) in [#873](connectrpc/connect-go#873), [#877](connectrpc/connect-go#877) - Add support for Edition 2024 by [@emcfarlane](https://github.com/emcfarlane) in [#878](connectrpc/connect-go#878) ##### Bugfixes - Include valid spec and headers when calling recover handler for streaming RPCs by [@jhump](https://github.com/jhump) in [#817](connectrpc/connect-go#817) ##### Other changes - Go version support updated to latest two instead of three by [@jhump](https://github.com/jhump) in [#837](connectrpc/connect-go#837) - CI testing improvements by [@pkwarren](https://github.com/pkwarren) and [@jhump](https://github.com/jhump) in [#838](connectrpc/connect-go#838), [#839](connectrpc/connect-go#839) - Code quality improvements by [@mattrobenolt](https://github.com/mattrobenolt) and [@bufdev](https://github.com/bufdev) in [#841](connectrpc/connect-go#841), [#867](connectrpc/connect-go#867) - Documentation improvements by [@adlion](https://github.com/adlion) and [@stefanvanburen](https://github.com/stefanvanburen) in [#821](connectrpc/connect-go#821), [#880](connectrpc/connect-go#880) #### New Contributors - [@adlion](https://github.com/adlion) made their first contribution in [#821](connectrpc/connect-go#821) - [@maxbrunet](https://github.com/maxbrunet) made their first contribution in [#873](connectrpc/connect-go#873) - [@stefanvanburen](https://github.com/stefanvanburen) made their first contribution in [#880](connectrpc/connect-go#880) **Full Changelog**: <connectrpc/connect-go@v1.18.1...v1.19.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1029 Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org> Co-authored-by: Renovate Bot <bot@kriese.eu> Co-committed-by: Renovate Bot <bot@kriese.eu>

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [connectrpc.com/connect](https://github.com/connectrpc/connect-go) | `v1.18.1` -> `v1.19.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/connectrpc.com%2fconnect/v1.19.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/connectrpc.com%2fconnect/v1.18.1/v1.19.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>connectrpc/connect-go (connectrpc.com/connect)</summary> ### [`v1.19.1`](https://github.com/connectrpc/connect-go/releases/tag/v1.19.1) [Compare Source](connectrpc/connect-go@v1.19.0...v1.19.1)  #### What's Changed ##### Bugfixes - Fix bounds check on envelope for 32-bit archs by [@emcfarlane](https://github.com/emcfarlane) in [#887](connectrpc/connect-go#887) - Fix CallInfo header/trailer propagation on error responses by [@emcfarlane](https://github.com/emcfarlane) in [#892](connectrpc/connect-go#892) **Full Changelog**: <connectrpc/connect-go@v1.19.0...v1.19.1> ### [`v1.19.0`](https://github.com/connectrpc/connect-go/releases/tag/v1.19.0) [Compare Source](connectrpc/connect-go@v1.18.1...v1.19.0) This release introduces the highly requested "simple" flag for code generation, making Connect significantly more ergonomic for everyday RPC development. The new simple flag in protoc-gen-connect-go generates cleaner, more intuitive client and handler interfaces that eliminate request/response wrappers for most use cases. This addresses community feedback about verbosity and provides a more straightforward API. When enabled, metadata (headers/trailers) can be passed through context instead of explicit wrapper objects, optimizing for the common case where developers don't need direct access to HTTP headers. #### What's Changed ##### Enhancements - Add simple flag for more ergonomic generated code by [@bufdev](https://github.com/bufdev) and [@smaye81](https://github.com/smaye81) in [#851](connectrpc/connect-go#851) - Update Go to v1.24 and document http.Protocol use removing the dependency on `golang.org/x/net/http2` by [@maxbrunet](https://github.com/maxbrunet) in [#873](connectrpc/connect-go#873), [#877](connectrpc/connect-go#877) - Add support for Edition 2024 by [@emcfarlane](https://github.com/emcfarlane) in [#878](connectrpc/connect-go#878) ##### Bugfixes - Include valid spec and headers when calling recover handler for streaming RPCs by [@jhump](https://github.com/jhump) in [#817](connectrpc/connect-go#817) ##### Other changes - Go version support updated to latest two instead of three by [@jhump](https://github.com/jhump) in [#837](connectrpc/connect-go#837) - CI testing improvements by [@pkwarren](https://github.com/pkwarren) and [@jhump](https://github.com/jhump) in [#838](connectrpc/connect-go#838), [#839](connectrpc/connect-go#839) - Code quality improvements by [@mattrobenolt](https://github.com/mattrobenolt) and [@bufdev](https://github.com/bufdev) in [#841](connectrpc/connect-go#841), [#867](connectrpc/connect-go#867) - Documentation improvements by [@adlion](https://github.com/adlion) and [@stefanvanburen](https://github.com/stefanvanburen) in [#821](connectrpc/connect-go#821), [#880](connectrpc/connect-go#880) #### New Contributors - [@adlion](https://github.com/adlion) made their first contribution in [#821](connectrpc/connect-go#821) - [@maxbrunet](https://github.com/maxbrunet) made their first contribution in [#873](connectrpc/connect-go#873) - [@stefanvanburen](https://github.com/stefanvanburen) made their first contribution in [#880](connectrpc/connect-go#880) **Full Changelog**: <connectrpc/connect-go@v1.18.1...v1.19.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1078 Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org> Co-authored-by: Renovate Bot <bot@kriese.eu> Co-committed-by: Renovate Bot <bot@kriese.eu>

jhump requested review from akshayjshah, bufdev, emcfarlane and mattrobenolt March 19, 2025 16:54

support latest two versions

8b8fdf5

Signed-off-by: Josh Humphries <2035234+jhump@users.noreply.github.com>

jhump force-pushed the jh/support-two-versions branch from e4f8364 to 8b8fdf5 Compare March 19, 2025 16:56

mattrobenolt approved these changes Mar 19, 2025

View reviewed changes

emcfarlane approved these changes Mar 19, 2025

View reviewed changes

bufdev approved these changes Mar 20, 2025

View reviewed changes

akshayjshah approved these changes Mar 21, 2025

View reviewed changes

use an indirect name for each go version so we don't have to change t…

3e75784

…he set of required checks when we change Go versions Signed-off-by: Josh Humphries <2035234+jhump@users.noreply.github.com>

jhump force-pushed the jh/support-two-versions branch from 123f33a to 3e75784 Compare March 24, 2025 18:55

jhump added 2 commits March 24, 2025 15:03

do the same for windows CI

2b6839e

Signed-off-by: Josh Humphries <2035234+jhump@users.noreply.github.com>

oops, fix name of conformance job

2b64e0b

Signed-off-by: Josh Humphries <2035234+jhump@users.noreply.github.com>

jhump changed the title ~~Proposal: support latest two versions of Go instead of latest three~~ Support latest two versions of Go instead of latest three Mar 24, 2025

jhump merged commit 9a579cb into main Mar 24, 2025
8 checks passed

jhump deleted the jh/support-two-versions branch March 24, 2025 21:05

nicksnyder mentioned this pull request Apr 4, 2025

Update to buf v2 config and latest golangci-lint connectrpc/grpchealth-go#76

Merged

emcfarlane mentioned this pull request Sep 24, 2025

Prepare for v1.19.0 #883

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support latest two versions of Go instead of latest three#837

Support latest two versions of Go instead of latest three#837
jhump merged 4 commits intomainfrom
jh/support-two-versions

jhump commented Mar 19, 2025

Uh oh!

mattrobenolt commented Mar 19, 2025

Uh oh!

akshayjshah left a comment

Uh oh!

jhump commented Mar 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jhump commented Mar 19, 2025

Uh oh!

mattrobenolt commented Mar 19, 2025

Uh oh!

akshayjshah left a comment

Choose a reason for hiding this comment

Uh oh!

jhump commented Mar 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants