Skip to content

Preserve symlinks#1312

Merged
h-vetinari merged 4 commits intoconda-forge:mainfrom
xhochy:preserve-lib-symlinks
Feb 20, 2024
Merged

Preserve symlinks#1312
h-vetinari merged 4 commits intoconda-forge:mainfrom
xhochy:preserve-lib-symlinks

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented Feb 19, 2024 •
edited by h-vetinari
Loading

@h-vetinari I would like to apply this on top of current PRs if you're happy with the change.

Closes #1307

@conda-forge-webservices
Copy link

conda-forge-webservices bot commented Feb 19, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

h-vetinari commented Feb 19, 2024

Yeah, sounds good to me. We need a fix from #1306 to unblock CI. If you want, I can then rebase #1307 and #1308 into this PR and we fix it in one go.

@xhochy
Copy link
Member Author

xhochy commented Feb 19, 2024

Yeah, sounds good to me. We need a fix from #1306 to unblock CI. If you want, I can then rebase #1307 and #1308 into this PR and we fix it in one go.

Yes, that sounds good (and what I thought and thus did not touch the build no).

@h-vetinari h-vetinari force-pushed the preserve-lib-symlinks branch from c421205 to c95abb3 Compare February 19, 2024 23:35
h-vetinari
h-vetinari approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Feb 19, 2024
@h-vetinari h-vetinari mentioned this pull request Feb 20, 2024
Merged
@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Feb 20, 2024
@h-vetinari h-vetinari merged commit affdeb7 into conda-forge:main Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h-vetinari h-vetinari h-vetinari approved these changes

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@jreback jreback Awaiting requested review from jreback jreback is a code owner

@kou kou Awaiting requested review from kou kou is a code owner

@kszucs kszucs Awaiting requested review from kszucs kszucs is a code owner

@leifwalsh leifwalsh Awaiting requested review from leifwalsh leifwalsh is a code owner

@nealrichardson nealrichardson Awaiting requested review from nealrichardson nealrichardson is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@pearu pearu Awaiting requested review from pearu pearu is a code owner

@pitrou pitrou Awaiting requested review from pitrou pitrou is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

@robertnishihara robertnishihara Awaiting requested review from robertnishihara robertnishihara is a code owner

@siddharthteotia siddharthteotia Awaiting requested review from siddharthteotia siddharthteotia is a code owner

@wesm wesm Awaiting requested review from wesm wesm is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xhochy @h-vetinari @regro-cf-autotick-bot