Skip to content

[main] Rebuild for aws_crt_cpp 0.26.2#1306

Merged
github-actions[bot] merged 3 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:rebuild-aws_crt_cpp0262-0-1_h4a527f
Feb 19, 2024
Merged

[main] Rebuild for aws_crt_cpp 0.26.2#1306
github-actions[bot] merged 3 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:rebuild-aws_crt_cpp0262-0-1_h4a527f

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Feb 15, 2024

This PR has been triggered in an effort to update aws_crt_cpp0262.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7918429815, please use this URL for debugging.

@conda-forge-webservices
Copy link

conda-forge-webservices bot commented Feb 15, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@raulcd
Copy link
Member

raulcd commented Feb 16, 2024

@h-vetinari any idea what is the problem with libabseil?

Traceback (most recent call last):
  File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 141, in mamba_get_install_actions
    solution = solver.solve_for_action(_specs, prefix)
  File "/opt/conda/lib/python3.10/site-packages/boa/core/solver.py", line 242, in solve_for_action
    t = self.solve(specs)
  File "/opt/conda/lib/python3.10/site-packages/boa/core/solver.py", line 232, in solve
    raise RuntimeError("Solver could not find solution." + error_string)
RuntimeError: Solver could not find solution.Mamba failed to solve:
 - _libgcc_mutex 0.1.* conda_forge
 - ca-certificates 2024.2.2.* hbcca054_0
 - libstdcxx-ng 13.2.0.* h7e041cc_5
 - libgomp 13.2.0.* h807b86a_5
 - _openmp_mutex 4.5.* 2_gnu
 - libgcc-ng 13.2.0.* h807b86a_5
 - icu 73.2.* h59595ed_0
 - libabseil 20240116.1.* cxx17_h59595ed_0
 - libiconv 1.17.* hd590300_2
 - libutf8proc 2.8.0.* h166bdaf_0
 - libzlib 1.2.13.* hd590300_5
 - openssl 3.2.1.* hd590300_0
 - xz 5.2.6.* h166bdaf_0
 - libre2-11 2023.06.02.* h5a48ba9_1
 - libxml2 2.12.5.* h232c23b_0
 - zstd 1.5.5.* hfc55251_0
 - libllvm15 15.0.7.* hb3ce162_4
 - re2 2023.06.02.* he738c6c_1
 - llvm 15.0.7.* hda56bd4_4
 - libarrow >=15.0.0,<16.0a0

with channels:

The reported errors are:
- Encountered problems while solving:
-   - package libarrow-15.0.0-h0809cb0_3_cpu requires libabseil >=20230802.1,<20230803.0a0, but none of the providers can be installed

@h-vetinari
Copy link
Member

h-vetinari commented Feb 16, 2024

Best guess: libarrow-flight-sql needs to host-depend on libabseil (and probably libgrpc).

The conflict error shows that it's trying to pull in - libabseil 20240116.1.* cxx17_h59595ed_0, which is incompatible with several other dependencies we have (as the migration for that hasn't started yet).

@raulcd
Copy link
Member

raulcd commented Feb 16, 2024

Best guess: libarrow-flight-sql needs to host-depend on libabseil (and probably libgrpc).

Thanks, let me give that a try locally as I am able to reproduce and I'll push.

@raulcd
Copy link
Member

raulcd commented Feb 19, 2024

It doesn't seem I have permissions to push to the regro-cf-autotick-bot branch:

Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:regro-cf-autotick-bot/arrow-cpp-feedstock.git
 ! [remote rejected] regro-cf/rebuild-aws_crt_cpp0262-0-1_h4a527f -> regro-cf/rebuild-aws_crt_cpp0262-0-1_h4a527f (permission denied)
error: failed to push some refs to 'github.com:regro-cf-autotick-bot/arrow-cpp-feedstock.git'

I tested locally just adding the following patch and it worked for python build-locally.py linux_64_c_compiler_version12cuda_compiler_versionNonecxx_compiler_version12:

diff --git a/recipe/meta.yaml b/recipe/meta.yaml
index 5b24b0b..ba92862 100644
--- a/recipe/meta.yaml
+++ b/recipe/meta.yaml
@@ -486,6 +486,7 @@ outputs:
         - openssl
         - re2
         - zlib  # [win]
+        - libabseil
       run:
         - {{ pin_subpackage("libarrow", exact=True) }}
       # run-constraints handled by libarrow, since we depend on it with exact=True

@h-vetinari
Copy link
Member

h-vetinari commented Feb 19, 2024

It doesn't seem I have permissions to push to the regro-cf-autotick-bot branch

Interesting, that always worked for me even before I joined core. On a given feedstock, I generally do something like the following:

git remote add bot https://github.com/regro-cf-autotick-bot/<package>-feedstock
git fetch bot
git checkout <branchname> (without specifying the remote; this automatically does a --track checkout)
# apply changes
git push bot

@raulcd
Copy link
Member

raulcd commented Feb 19, 2024

Interesting, that always worked for me even before I joined core. On a given feedstock, I generally do something like the following:

That's pretty much what I did, I'll try again in the future following exactly as I did the track manually.

btw I had to add libabseil to libarrow-gandiva not libarrow-flight-sql but let's see the current CI.

@h-vetinari
Copy link
Member

h-vetinari commented Feb 19, 2024

I tested locally just adding the following patch and it worked for python build-locally.py [...]

Ah, just saw that you applied this to libarrow-gandiva - yeah, I had probably gotten the output wrong - I suspected it would have been the one following libarrow-flight (as that was when the error occurred), but forgot that libarrow-flight-sql is actually ordered further back in the topological sort of the subpackage graph.

@h-vetinari @raulcd
add libabseil as a host-dep to libarrow-gandiva
2bf9830 
Co-Authored-By: Raúl Cumplido <raulcumplido@gmail.com>
@h-vetinari h-vetinari force-pushed the rebuild-aws_crt_cpp0262-0-1_h4a527f branch from 4011c61 to 2bf9830 Compare February 19, 2024 11:28
@h-vetinari
Copy link
Member

h-vetinari commented Feb 19, 2024

That's pretty much what I did, I'll try again in the future following exactly as I did the track manually.

The --track shouldn't be necessary for whether you have the rights or not. It's strange to me. You should definitely have the rights as a maintainer... The one thing I'm doing is that I'm pushing to ssh://<my-ssh-identity-for-github>/regro-cf-autotick-bot/arrow-cpp-feedstock, not to github.com:regro-cf-autotick-bot/arrow-cpp-feedstock.git. Perhaps try with an SSH setup?

@h-vetinari h-vetinari changed the title Rebuild for aws_crt_cpp 0.26.2 [main] Rebuild for aws_crt_cpp 0.26.2 Feb 19, 2024
@h-vetinari h-vetinari mentioned this pull request Feb 19, 2024
Closed
@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Feb 19, 2024
This was referenced Feb 19, 2024
Merged
Merged
Merged
@xhochy
Copy link
Member

xhochy commented Feb 19, 2024

Alternative way (that I do) is to use the GitHub CLI and checkout the branch using gh pr checkout <no>. This also sets up the remotes correctly.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari mentioned this pull request Feb 19, 2024
Merged
@github-actions github-actions bot merged commit 1027615 into conda-forge:main Feb 19, 2024
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-aws_crt_cpp0262-0-1_h4a527f branch February 19, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h-vetinari h-vetinari h-vetinari approved these changes

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@jreback jreback Awaiting requested review from jreback jreback is a code owner

@kou kou Awaiting requested review from kou kou is a code owner

@kszucs kszucs Awaiting requested review from kszucs kszucs is a code owner

@leifwalsh leifwalsh Awaiting requested review from leifwalsh leifwalsh is a code owner

@nealrichardson nealrichardson Awaiting requested review from nealrichardson nealrichardson is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@pearu pearu Awaiting requested review from pearu pearu is a code owner

@pitrou pitrou Awaiting requested review from pitrou pitrou is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

@robertnishihara robertnishihara Awaiting requested review from robertnishihara robertnishihara is a code owner

@siddharthteotia siddharthteotia Awaiting requested review from siddharthteotia siddharthteotia is a code owner

@wesm wesm Awaiting requested review from wesm wesm is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees

No one assigned

Labels

automerge Merge the PR when CI passes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@regro-cf-autotick-bot @raulcd @h-vetinari @xhochy