Skip to content

[main] Rebuild for glog 0.7#1308

Merged
xhochy merged 3 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:rebuild-glog07-0-1_hc92393
Feb 22, 2024
Merged

[main] Rebuild for glog 0.7#1308
xhochy merged 3 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:rebuild-glog07-0-1_hc92393

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Feb 18, 2024

This PR has been triggered in an effort to update glog07.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

  • heavydb-ext
    and potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7950380652, please use this URL for debugging.

@conda-forge-webservices
Copy link

conda-forge-webservices bot commented Feb 18, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari changed the title Rebuild for glog 0.7 [main] Rebuild for glog 0.7 Feb 19, 2024
@h-vetinari h-vetinari marked this pull request as draft February 19, 2024 11:34
This was referenced Feb 19, 2024
Merged
Merged
Merged
Merged
Open
@h-vetinari h-vetinari force-pushed the rebuild-glog07-0-1_hc92393 branch from 1d5916a to 18ab802 Compare February 21, 2024 08:36
@h-vetinari
Copy link
Member

h-vetinari commented Feb 21, 2024

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits February 21, 2024 08:48
@h-vetinari
Copy link
Member

h-vetinari commented Feb 21, 2024

Cool thanks a lot!

Would you mind opening a PR upstream? I can also open a PR with your commit if you prefer.

@xhochy
Copy link
Member

xhochy commented Feb 21, 2024

I will push an upstream PR later. For upstream, I would spent a bit more time and go through some more testing on whether we could remove FindGLOG.cmake in Arrow completely.

@h-vetinari h-vetinari mentioned this pull request Feb 21, 2024
Closed
@h-vetinari
Copy link
Member

h-vetinari commented Feb 21, 2024

Sounds great, thanks. I opened an upstream issue for tracking, you can move proposals/discussion there.

Should we wait with merging this PR for how things turn out upstream?

@xhochy
Copy link
Member

xhochy commented Feb 21, 2024 •
edited
Loading

I would be eager to merge here as at least the relevant CMake code is untouched since I have written it years ago,

@h-vetinari h-vetinari marked this pull request as ready for review February 21, 2024 14:43
h-vetinari
h-vetinari approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, go for it! Needs backports to all the maintenance branches too though...

@xhochy xhochy merged commit 1fedf3c into conda-forge:main Feb 22, 2024
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-glog07-0-1_hc92393 branch February 22, 2024 08:40
@h-vetinari
Copy link
Member

h-vetinari commented Feb 22, 2024

Will you prepare the backports?

@xhochy
Copy link
Member

xhochy commented Feb 22, 2024

On it already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h-vetinari h-vetinari h-vetinari approved these changes

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@jreback jreback Awaiting requested review from jreback jreback is a code owner

@kou kou Awaiting requested review from kou kou is a code owner

@kszucs kszucs Awaiting requested review from kszucs kszucs is a code owner

@leifwalsh leifwalsh Awaiting requested review from leifwalsh leifwalsh is a code owner

@nealrichardson nealrichardson Awaiting requested review from nealrichardson nealrichardson is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@pearu pearu Awaiting requested review from pearu pearu is a code owner

@pitrou pitrou Awaiting requested review from pitrou pitrou is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

@robertnishihara robertnishihara Awaiting requested review from robertnishihara robertnishihara is a code owner

@siddharthteotia siddharthteotia Awaiting requested review from siddharthteotia siddharthteotia is a code owner

@wesm wesm Awaiting requested review from wesm wesm is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@regro-cf-autotick-bot @h-vetinari @xhochy