Optimism-Goerli proposal by kevincheng96 · Pull Request #726 · compound-finance/comet

kevincheng96 · 2023-03-27T19:26:11Z

This PR creates the Optimism-Goerli migration script for launching cUSDCv3. This PR also updates the Optimism message-passing bridge relayer logic in our scenarios so we can test token bridging using scenarios.

Proposal 70 created and executed: https://goerli.etherscan.io/tx/0x6defeea621b4778cfab509ea5ed5ce2ed4da78535dc75e787312b78413e88aaf

Execution of proposal on Optimism Goerli: https://goerli-optimism.etherscan.io/tx/0x465b0e6863afeb1640336b6843b4b03ce51a13b01cae51f04638cd4054a41392

deployments/optimism-goerli/usdc/migrations/1679592519_configurate_and_ens.ts

deployments/goerli/usdc/relations.ts

deployments/optimism-goerli/usdc/migrations/1679592519_configurate_and_ens.ts

jflatow

Looking great 🏆

deployments/optimism-goerli/usdc/configuration.json

kevincheng96 · 2023-04-04T18:49:14Z

deployments/optimism-goerli/usdc/migrations/1679592519_configurate_and_ens.ts

+    const stateChanges = await diffState(comet, getCometConfig, preMigrationBlockNumber);
+    expect(stateChanges).to.deep.equal({
+      pauseGuardian: '0xe7661C55fe281f986FA5312D57d19ADb6064462F',
+      baseTrackingSupplySpeed: exp(0.000011574074074, 15, 15).toString(),
+      baseTrackingBorrowSpeed: exp(0.001145833333333, 15, 15).toString(),
+      baseMinForRewards: exp(10_000, 6).toString(),
+      targetReserves: exp(1_000_000, 6).toString(),
+      OP: {
+        supplyCap: exp(1_000_000, 18)
+      },
+      WBTC: {
+        supplyCap: exp(20_000, 8)
+      },
+      WETH: {
+        supplyCap: exp(50_000, 18)
+      }
+    })


We use the differ to verify state changes here.

kevincheng96 · 2023-04-04T20:18:32Z

Proposal 67 created https://github.com/compound-finance/comet/actions/runs/4611903757/jobs/8152176787

… for scenarios

kevincheng96 · 2023-04-05T00:17:56Z

Re-running this migration because we re-deployed Comet on Optimism-Goerli. See #710 (comment) for context.

kevincheng96 · 2023-04-05T04:35:34Z

Proposal 70 created and executed: https://goerli.etherscan.io/tx/0x6defeea621b4778cfab509ea5ed5ce2ed4da78535dc75e787312b78413e88aaf

Execution of proposal on Optimism Goerli: https://goerli-optimism.etherscan.io/tx/0x465b0e6863afeb1640336b6843b4b03ce51a13b01cae51f04638cd4054a41392

* Optimism testnet deploy * WIP * Allow `existing` to merge into a proxy and use for optimism-goerli * Fix cross-chain scenario by passing in gasLimit from the L1 txn * Update deploy and bump hardhat * Fix Optimism scenarios (#721) * Add logs when executing a bridged proposal * Add new regex to custom error checker * Use separate Etherscan API key for optimism * Add USDC whale for optimism-goerli * Add revert error message for WETH * More scenario fixes * Fix remaining scenario errors * Add case for optimism-goerli to createCrossChainProposal * Add optimism etherscan key to forge test job * Update collateral assets and deploy script * Update WBTC supply cap decimals * Deploy Comet to Optimism-Goerli and upload VerifyArgs when deploy fails (#728) We deploy Comet to Optimism-Goerli and update the roots in this PR. This PR also improves the deploy step by allowing us to recover the `VerifyArgs` if a deploy job fails mid-deploy. This also includes a fix for verifying contracts in Optimism-Goerli. --------- Co-authored-by: GitHub Actions Bot <> Co-authored-by: Jared Flatow <jflatow@gmail.com> * Update timelock constructor params in deploy script * Remove roots for re-deploy * Modified deployment roots from GitHub Actions * Optimism-Goerli proposal (#726) This PR creates the Optimism-Goerli migration script for launching cUSDCv3. This PR also updates the Optimism message-passing bridge relayer logic in our scenarios so we can test token bridging using scenarios. Proposal 70 created and executed: https://goerli.etherscan.io/tx/0x6defeea621b4778cfab509ea5ed5ce2ed4da78535dc75e787312b78413e88aaf Execution of proposal on Optimism Goerli: https://goerli-optimism.etherscan.io/tx/0x465b0e6863afeb1640336b6843b4b03ce51a13b01cae51f04638cd4054a41392 --------- Co-authored-by: GitHub Actions Bot <> --------- Co-authored-by: Jared Flatow <jflatow@gmail.com> Co-authored-by: kevincheng96 <kevincheng96@hotmail.com> Co-authored-by: GitHub Actions Bot <>

* Optimism Deployment base configuration.json add optimism values to etherscan.ts relations base relayPolygonMessage add isBridgeProposal rename to relayOptimismMessage add optimismL1CrossDomainMessenger to mainnet/usdc deploy partial relayOptimismMessage impl relayOptimismMessage impl cont'd optimism deploy script complete relayOptimismMessage impl bump supply caps rename iface applyL1ToL2Alias helper bridge receiver contract add crossDomainMessenger arg to constructor in deplooy.ts add scenario, matchesDeployment helper reuse CROSS_DOMAIN_MESSENGER lint update Github Actions update asset information * Incorporate Optimism audit feedback (#699) update comment in Optimism deploy script update Bulker path I for Interface Optimism deployment misc fixes (#701) * WETH whale * add optimismL1CrossDomainManager to roots * Optimism testnet deployment (#710) * Optimism testnet deploy * WIP * Allow `existing` to merge into a proxy and use for optimism-goerli * Fix cross-chain scenario by passing in gasLimit from the L1 txn * Update deploy and bump hardhat * Fix Optimism scenarios (#721) * Add logs when executing a bridged proposal * Add new regex to custom error checker * Use separate Etherscan API key for optimism * Add USDC whale for optimism-goerli * Add revert error message for WETH * More scenario fixes * Fix remaining scenario errors * Add case for optimism-goerli to createCrossChainProposal * Add optimism etherscan key to forge test job * Update collateral assets and deploy script * Update WBTC supply cap decimals * Deploy Comet to Optimism-Goerli and upload VerifyArgs when deploy fails (#728) We deploy Comet to Optimism-Goerli and update the roots in this PR. This PR also improves the deploy step by allowing us to recover the `VerifyArgs` if a deploy job fails mid-deploy. This also includes a fix for verifying contracts in Optimism-Goerli. --------- Co-authored-by: GitHub Actions Bot <> Co-authored-by: Jared Flatow <jflatow@gmail.com> * Update timelock constructor params in deploy script * Remove roots for re-deploy * Modified deployment roots from GitHub Actions * Optimism-Goerli proposal (#726) This PR creates the Optimism-Goerli migration script for launching cUSDCv3. This PR also updates the Optimism message-passing bridge relayer logic in our scenarios so we can test token bridging using scenarios. Proposal 70 created and executed: https://goerli.etherscan.io/tx/0x6defeea621b4778cfab509ea5ed5ce2ed4da78535dc75e787312b78413e88aaf Execution of proposal on Optimism Goerli: https://goerli-optimism.etherscan.io/tx/0x465b0e6863afeb1640336b6843b4b03ce51a13b01cae51f04638cd4054a41392 --------- Co-authored-by: GitHub Actions Bot <> --------- Co-authored-by: Jared Flatow <jflatow@gmail.com> Co-authored-by: kevincheng96 <kevincheng96@hotmail.com> Co-authored-by: GitHub Actions Bot <> * Fix comment * Support Base Goerli * Address feedback for Base Goerli * Remove all codepaths related to Optimism Mainnet * Add cbETH as collateral asset and set supply caps to 0 for deploy * Formatting * Re-order asset configuration because WETH being the first asset breaks the bulker scenario * Modified deployment roots from GitHub Actions * Update configuration for pause guardian and supply caps; check diffState in proposal * Modified migration from GitHub Actions --------- Co-authored-by: Scott Silver <scott@compound.finance> Co-authored-by: Jared Flatow <jflatow@gmail.com> Co-authored-by: GitHub Actions Bot <>

kevincheng96 commented Mar 27, 2023

View reviewed changes

deployments/optimism-goerli/usdc/migrations/1679592519_configurate_and_ens.ts Outdated Show resolved Hide resolved

kevincheng96 force-pushed the kevin/op-testnet-proposal branch from 236da86 to cb9445f Compare March 27, 2023 23:58

kevincheng96 requested review from jflatow and scott-silver March 27, 2023 23:59

jflatow reviewed Mar 28, 2023

View reviewed changes

deployments/goerli/usdc/relations.ts Show resolved Hide resolved

jflatow reviewed Mar 28, 2023

View reviewed changes

deployments/optimism-goerli/usdc/migrations/1679592519_configurate_and_ens.ts Outdated Show resolved Hide resolved

jflatow approved these changes Mar 28, 2023

View reviewed changes

jflatow reviewed Mar 28, 2023

View reviewed changes

deployments/optimism-goerli/usdc/configuration.json Show resolved Hide resolved

kevincheng96 force-pushed the silver/optimism-deployment-testnet branch 2 times, most recently from 3ff7466 to 09b1f81 Compare March 31, 2023 23:48

kevincheng96 force-pushed the kevin/op-testnet-proposal branch from 4e055fe to 48e4624 Compare April 1, 2023 00:01

This comment was marked as spam.

Sign in to view

kevincheng96 force-pushed the silver/optimism-deployment-testnet branch from 09b1f81 to c920060 Compare April 4, 2023 17:16

kevincheng96 force-pushed the kevin/op-testnet-proposal branch from 6d22fb1 to 9510860 Compare April 4, 2023 17:20

kevincheng96 force-pushed the silver/optimism-deployment-testnet branch from c920060 to b3f9345 Compare April 4, 2023 17:29

kevincheng96 force-pushed the kevin/op-testnet-proposal branch from 9510860 to 1a7e23a Compare April 4, 2023 17:46

kevincheng96 commented Apr 4, 2023

View reviewed changes

kevincheng96 and others added 10 commits April 4, 2023 17:12

Create Optimism-Goerli proposal; implement token bridging relay logic…

092cb8a

… for scenarios

Fix lint

84cf383

Update proposal action numbers

f548952

Add pauseGuardian address

76b1085

Fix bulker scenario

54d2d0c

Add action to set reward config; lower gas limits

2ca92f4

Use differ to verify state changes after the migration

f6ab771

Add governance networks for optimism to enact GH action

4662c38

Modified migration from GitHub Actions

ae73810

Fix proposal title

cb356da

kevincheng96 force-pushed the kevin/op-testnet-proposal branch from 5298c59 to 5075972 Compare April 5, 2023 00:13

kevincheng96 force-pushed the kevin/op-testnet-proposal branch from 5075972 to cb356da Compare April 5, 2023 04:26

Don't run verify on migrations that have already been enacted

e862317

kevincheng96 merged commit ed524e3 into silver/optimism-deployment-testnet Apr 5, 2023

kevincheng96 deleted the kevin/op-testnet-proposal branch April 5, 2023 05:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimism-Goerli proposal#726

Optimism-Goerli proposal#726
kevincheng96 merged 11 commits intosilver/optimism-deployment-testnetfrom
kevin/op-testnet-proposal

kevincheng96 commented Mar 27, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jflatow left a comment

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

kevincheng96 Apr 4, 2023

Uh oh!

kevincheng96 commented Apr 4, 2023

Uh oh!

kevincheng96 commented Apr 5, 2023

Uh oh!

kevincheng96 commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kevincheng96 commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jflatow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

kevincheng96 Apr 4, 2023

Choose a reason for hiding this comment

Uh oh!

kevincheng96 commented Apr 4, 2023

Uh oh!

kevincheng96 commented Apr 5, 2023

Uh oh!

kevincheng96 commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kevincheng96 commented Mar 27, 2023 •

edited

Loading