Skip to content

Optimism deployment OZ feedback#699

Merged
jflatow merged 1 commit intosilver/optimism-deploymentfrom
silver/optimism-deployment-feedback
Mar 8, 2023
Merged

Optimism deployment OZ feedback#699
jflatow merged 1 commit intosilver/optimism-deploymentfrom
silver/optimism-deployment-feedback

Conversation

@scott-silver
Copy link
Copy Markdown
Contributor

@scott-silver scott-silver commented Feb 27, 2023

Addresses the following pieces of feedback from OpenZeppelin:

  • N01 - Multiple assets per file
  • N02 - Deployment script has comment referring to Polygon instead of Optimism

Also updates the contract path for the Bulker.sol

@scott-silver scott-silver force-pushed the silver/optimism-deployment-feedback branch from 5b4b584 to 25ff9cd Compare February 27, 2023 23:39
Copy link
Copy Markdown
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Copy Markdown
Contributor

@jflatow jflatow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@scott-silver scott-silver mentioned this pull request Feb 28, 2023
18 tasks
@jflatow jflatow force-pushed the silver/optimism-deployment branch from 5643713 to 37f15fb Compare February 28, 2023 18:53
@jflatow jflatow force-pushed the silver/optimism-deployment branch from 37f15fb to 6695f95 Compare March 8, 2023 19:12
update comment in Optimism deploy script

update Bulker path

I for Interface

Optimism deployment misc fixes (#701)

* WETH whale

* add optimismL1CrossDomainManager to roots
@jflatow jflatow force-pushed the silver/optimism-deployment-feedback branch from f879f9a to 32bf496 Compare March 8, 2023 19:23
@jflatow jflatow merged commit c33bd5f into silver/optimism-deployment Mar 8, 2023
kevincheng96 pushed a commit that referenced this pull request Mar 16, 2023
update comment in Optimism deploy script

update Bulker path

I for Interface

Optimism deployment misc fixes (#701)

* WETH whale

* add optimismL1CrossDomainManager to roots
kevincheng96 pushed a commit that referenced this pull request Mar 21, 2023
update comment in Optimism deploy script

update Bulker path

I for Interface

Optimism deployment misc fixes (#701)

* WETH whale

* add optimismL1CrossDomainManager to roots
kevincheng96 pushed a commit that referenced this pull request Mar 31, 2023
update comment in Optimism deploy script

update Bulker path

I for Interface

Optimism deployment misc fixes (#701)

* WETH whale

* add optimismL1CrossDomainManager to roots
kevincheng96 pushed a commit that referenced this pull request Mar 31, 2023
update comment in Optimism deploy script

update Bulker path

I for Interface

Optimism deployment misc fixes (#701)

* WETH whale

* add optimismL1CrossDomainManager to roots
kevincheng96 pushed a commit that referenced this pull request Apr 4, 2023
update comment in Optimism deploy script

update Bulker path

I for Interface

Optimism deployment misc fixes (#701)

* WETH whale

* add optimismL1CrossDomainManager to roots
kevincheng96 pushed a commit that referenced this pull request May 22, 2023
update comment in Optimism deploy script

update Bulker path

I for Interface

Optimism deployment misc fixes (#701)

* WETH whale

* add optimismL1CrossDomainManager to roots
kevincheng96 pushed a commit that referenced this pull request Jun 1, 2023
update comment in Optimism deploy script

update Bulker path

I for Interface

Optimism deployment misc fixes (#701)

* WETH whale

* add optimismL1CrossDomainManager to roots
kevincheng96 added a commit that referenced this pull request Jun 1, 2023
* Optimism Deployment

base configuration.json

add optimism values to etherscan.ts

relations

base relayPolygonMessage

add isBridgeProposal

rename to relayOptimismMessage

add optimismL1CrossDomainMessenger to mainnet/usdc deploy

partial relayOptimismMessage impl

relayOptimismMessage impl cont'd

optimism deploy script

complete relayOptimismMessage impl

bump supply caps

rename iface

applyL1ToL2Alias helper

bridge receiver contract

add crossDomainMessenger arg to constructor in deplooy.ts

add scenario, matchesDeployment helper

reuse CROSS_DOMAIN_MESSENGER

lint

update Github Actions

update asset information

* Incorporate Optimism audit feedback (#699)

update comment in Optimism deploy script

update Bulker path

I for Interface

Optimism deployment misc fixes (#701)

* WETH whale

* add optimismL1CrossDomainManager to roots

* Optimism testnet deployment (#710)

* Optimism testnet deploy

* WIP

* Allow `existing` to merge into a proxy and use for optimism-goerli

* Fix cross-chain scenario by passing in gasLimit from the L1 txn

* Update deploy and bump hardhat

* Fix Optimism scenarios (#721)

* Add logs when executing a bridged proposal

* Add new regex to custom error checker

* Use separate Etherscan API key for optimism

* Add USDC whale for optimism-goerli

* Add revert error message for WETH

* More scenario fixes

* Fix remaining scenario errors

* Add case for optimism-goerli to createCrossChainProposal

* Add optimism etherscan key to forge test job

* Update collateral assets and deploy script

* Update WBTC supply cap decimals

* Deploy Comet to Optimism-Goerli and upload VerifyArgs when deploy fails (#728)

We deploy Comet to Optimism-Goerli and update the roots in this PR. This PR also improves the deploy step by allowing us to recover the `VerifyArgs` if a deploy job fails mid-deploy. This also includes a fix for verifying contracts in Optimism-Goerli.

---------

Co-authored-by: GitHub Actions Bot <>
Co-authored-by: Jared Flatow <jflatow@gmail.com>

* Update timelock constructor params in deploy script

* Remove roots for re-deploy

* Modified deployment roots from GitHub Actions

* Optimism-Goerli proposal (#726)

This PR creates the Optimism-Goerli migration script for launching cUSDCv3. This PR also updates the Optimism message-passing bridge relayer logic in our scenarios so we can test token bridging using scenarios.

Proposal 70 created and executed: https://goerli.etherscan.io/tx/0x6defeea621b4778cfab509ea5ed5ce2ed4da78535dc75e787312b78413e88aaf

Execution of proposal on Optimism Goerli: https://goerli-optimism.etherscan.io/tx/0x465b0e6863afeb1640336b6843b4b03ce51a13b01cae51f04638cd4054a41392

---------

Co-authored-by: GitHub Actions Bot <>

---------

Co-authored-by: Jared Flatow <jflatow@gmail.com>
Co-authored-by: kevincheng96 <kevincheng96@hotmail.com>
Co-authored-by: GitHub Actions Bot <>

* Fix comment

* Support Base Goerli

* Address feedback for Base Goerli

* Remove all codepaths related to Optimism Mainnet

* Add cbETH as collateral asset and set supply caps to 0 for deploy

* Formatting

* Re-order asset configuration because WETH being the first asset breaks the bulker scenario

* Modified deployment roots from GitHub Actions

* Update configuration for pause guardian and supply caps; check diffState in proposal

* Modified migration from GitHub Actions

---------

Co-authored-by: Scott Silver <scott@compound.finance>
Co-authored-by: Jared Flatow <jflatow@gmail.com>
Co-authored-by: GitHub Actions Bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants