Skip to content

Relax ruamel.yaml dependancy cap and support python 3.7#831

Merged
mr-c merged 8 commits intomasterfrom
python_3_7_support
Jul 19, 2018
Merged

Relax ruamel.yaml dependancy cap and support python 3.7#831
mr-c merged 8 commits intomasterfrom
python_3_7_support

Conversation

@ThomasHickman
Copy link
Member

@ThomasHickman ThomasHickman commented Jul 17, 2018 •
edited
Loading

Following on from common-workflow-language/schema_salad#189 and fixes #822

@codecov
Copy link

codecov bot commented Jul 17, 2018 •
edited
Loading

Codecov Report

Merging #831 into master will increase coverage by 4.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   67.12%   72.09%   +4.97%     
==========================================
  Files          30       34       +4     
  Lines        5582     6154     +572     
  Branches     1411     1564     +153     
==========================================
+ Hits         3747     4437     +690     
+ Misses       1431     1282     -149     
- Partials      404      435      +31
Impacted Files Coverage Δ
cwltool/docker_id.py 48.97% <0%> (-2.09%) ⬇️
cwltool/context.py 96.42% <0%> (-0.87%) ⬇️
cwltool/main.py 35.78% <0%> (ø)
cwltool/flatten.py 78.94% <0%> (ø)
cwltool/utils.py 47.48% <0%> (ø)
cwltool/__init__.py 100% <0%> (ø)
cwltool/software_requirements.py 29.72% <0%> (+1.35%) ⬆️
cwltool/load_tool.py 82.67% <0%> (+1.48%) ⬆️
cwltool/argparser.py 83.73% <0%> (+2.39%) ⬆️
cwltool/job.py 63.15% <0%> (+3.4%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d72da0...8e126ee. Read the comment docs.

@mr-c
Copy link
Member

mr-c commented Jul 17, 2018 •
edited
Loading

lxml has wheels for manylinux1 & py37 but not yet windows: https://pypi.org/project/lxml/#files

https://bugs.launchpad.net/lxml/+bug/1757938

https://mailman-mail5.webfaction.com/pipermail/lxml/2018-July/023964.html

@ThomasHickman
Copy link
Member Author

ThomasHickman commented Jul 19, 2018

Note: I added an issue to typings for the python 3.7 typing bug we are finding: python/typing#573. Their solution is to not require typing for python 3.5+, as it is built in (which is fair enough). I think we should implement this

@ThomasHickman
Copy link
Member Author

ThomasHickman commented Jul 19, 2018

^ changed that to basically typing>=3.5.3; python_version < "3.7" as python 3.7 is the first release where typing is not released as "provisional"

@mr-c mr-c merged commit 7f8a62c into master Jul 19, 2018
@mr-c mr-c deleted the python_3_7_support branch July 19, 2018 11:23
@mr-c
Copy link
Member

mr-c commented Jul 19, 2018

@ThomasHickman Thanks!

@nsoranzo nsoranzo mentioned this pull request Aug 31, 2018
Closed
nsoranzo added a commit to nsoranzo/planemo that referenced this pull request Aug 31, 2018
@nsoranzo
Update cwltool dependencies for Python 3.7
ec7a4ab 
Need a release which includes
common-workflow-language/cwltool#831 .
nsoranzo added a commit to nsoranzo/planemo that referenced this pull request Aug 31, 2018
@nsoranzo
Update cwltool dependencies for Python 3.7
709f227 
Fix galaxyproject#863 .

Need a release which includes
common-workflow-language/cwltool#831 .
@nsoranzo nsoranzo mentioned this pull request Aug 31, 2018
Merged
nsoranzo added a commit to nsoranzo/planemo that referenced this pull request Sep 12, 2018
@nsoranzo
Update cwltool and galaxy-lib dependencies for Python 3.7
e96745e 
Fix galaxyproject#863 .

Need releases which include respectively:
common-workflow-language/cwltool#831
galaxyproject/galaxy-lib#129
nsoranzo added a commit to nsoranzo/planemo that referenced this pull request Sep 13, 2018
@nsoranzo
Update cwltool and galaxy-lib dependencies for Python 3.7
9250c2b 
Fix galaxyproject#863 .

Need releases which include:
common-workflow-language/cwltool#831
galaxyproject/galaxy-lib#129
galaxyproject/galaxy-lib@c68f729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cwltool fails to install in python3.7

2 participants

@ThomasHickman @mr-c