Relax ruamel.yaml dependency and support python 3.7 by ThomasHickman · Pull Request #189 · common-workflow-language/schema_salad

ThomasHickman · 2018-07-16T09:50:32Z

ruamel.yaml<0.15.37 fails to install with python >= 3.7, as this works with ruamel.yaml>0.15, we should allow that to happen. See common-workflow-language/cwltool#822

`ruamel.yaml<0.15.37` fails to install with python >= 3.7, as this works with `ruamel.yaml>0.15`, we should allow that to happen.

mr-c

Thanks! Can you add in the appropriate TravisCI and Appveyor, and setup.py classifiers changes too?

https://github.com/common-workflow-language/schema_salad/pull/189/files#diff-2eeaed663bd0d25b7e608891384b7298L68

psafont · 2018-07-16T11:05:21Z

.travis.yml

  - 3.4
  - 3.5
  - 3.6
+  - 3.7


This will fail, travis support for 3.7 requires some effort: 3.7 only works on xenial with sudo enabled; and 3.4 only works on trusty, see travis-ci/travis-ci#9815

Example: https://github.com/jdufresne/psycopg2/blob/a8b9c9971ea18d7581a8aba8cb3b5f336b33672b/.travis.yml

tetron · 2018-07-16T13:34:46Z

setup.py

    'setuptools',
    'requests >= 1.0',
-    'ruamel.yaml >= 0.12.4, < 0.15',
+    'ruamel.yaml >= 0.12.4',


How about changing that to < 0.16 in case there's another new version? (ruamel.yaml seems to be treating the minor version as if it were the major version...)

This only works with this configuration. See travis-ci/travis-ci#9815

ThomasHickman · 2018-07-16T15:51:37Z

Could someone with a windows machine debug the windows failures? I'm having difficulty debugging it on a windows virtual machine.

mr-c · 2018-07-17T06:13:57Z

I'm working on the appveyor side, something isn't right with TravisCI:

Worker information
hostname: b84634ea-8282-4f0c-9139-2f6555ef76f0@1.production-2-worker-org-03-packet.packet-ewr1.travisci.net
version: v3.10.1 https://github.com/travis-ci/worker/tree/2f4923494b1f57289a2d4b68a0861e882a7215ad
instance: a316c4c travisci/ci-garnet:packer-1512502276-986baf0 (via amqp)
startup: 892.754443ms
/home/travis/.travis/job_stages: line 521: syntax error in conditional expression
/home/travis/.travis/job_stages: line 521: syntax error near `"xenial"]/bin/activate'
/home/travis/.travis/job_stages: line 521: `if [[ ! -f ~/virtualenv/python[:dist, "xenial"]/bin/activate ]]; then'
travis_run_configure: command not found
travis_run_prepare: command not found
travis_run_disable_sudo: command not found
travis_run_checkout: command not found
travis_run_export: command not found
travis_run_setup: command not found
travis_run_setup_casher: command not found
travis_run_setup_cache: command not found
travis_run_announce: command not found
travis_run_debug: command not found
travis_run_before_install: command not found
travis_run_install: command not found
travis_run_before_script: command not found
travis_run_script: command not found
travis_run_before_cache: command not found
travis_run_cache: command not found
travis_run_after_success: command not found
travis_run_after_failure: command not found
travis_run_after_script: command not found
travis_run_finish: command not found
Done. Your build exited with .

https://travis-ci.org/common-workflow-language/schema_salad/jobs/404748729

ThomasHickman · 2018-07-17T08:10:37Z

Ah, that must be due to me using

python:
  - 2.7
  - 3.4
  - 3.5
  - 3.6
  - python: 3.7
    dist: xenial
    sudo: true

to specify the python versions. I hoped it would work correctly, but instead it seems to have triggered a bug in travis (reported at https://travis-ci.org/common-workflow-language/schema_salad/jobs/404748729#L1)

see https://docs.travis-ci.com/user/customizing-the-build/#Explicitly-included-jobs-inherit-the-first-value-in-the-array

ThomasHickman · 2018-07-17T11:19:38Z

^ I think you can get python 3.4 tested by using

  include:
    - stage: test
      python: "2.7"
    - stage: test
      python: "3.4"
    - stage: test
      python: "3.5"
    - stage: test
      python: "3.6"
    - stage: test
      python: "3.7"
      dist: xenial
      sudo: required
    - stage: release-test
      script: RELEASE_SKIP=head PYVER= ./release-test.sh

mr-c · 2018-07-17T11:20:23Z

@ThomasHickman You are welcome to iterate on that in another PR 😭

Relax ruamel.yaml dependancy

2d989b1

`ruamel.yaml<0.15.37` fails to install with python >= 3.7, as this works with `ruamel.yaml>0.15`, we should allow that to happen.

ThomasHickman changed the title ~~Relax ruamel.yaml dependancy~~ Relax ruamel.yaml dependency Jul 16, 2018

mr-c requested changes Jul 16, 2018

View reviewed changes

Support python 3.7

45e4f06

psafont reviewed Jul 16, 2018

View reviewed changes

tetron reviewed Jul 16, 2018

View reviewed changes

ThomasHickman added 2 commits July 16, 2018 16:11

Make python3.7 image use xenial and sudo: true

5150754

This only works with this configuration. See travis-ci/travis-ci#9815

Cap ruamel.yaml version and update requirements.txt

afe238f

mr-c added 2 commits July 17, 2018 09:07

try latest setuptools & pip with appveyor

6f53e26

fix quoting

c66a59c

Correct build matrix

8b09872

ThomasHickman changed the title ~~Relax ruamel.yaml dependency~~ Relax ruamel.yaml dependency and support python 3.7 Jul 17, 2018

ThomasHickman and others added 15 commits July 17, 2018 10:20

Try again with the travis build matrix

a1af6c7

bump typing dependency

979ecd4

bump typing dependency

0291d2f

remove parallel test exectution

9467dca

make even the matrix

0eb451b

another try at the TravisCI matrix

4d0c643

another try

cdc9286

a simpler approach

9d26bec

3.7 has to be the first in the list

7f5012b

see https://docs.travis-ci.com/user/customizing-the-build/#Explicitly-included-jobs-inherit-the-first-value-in-the-array

be explicit, take 2

a59f20c

quote the python versions

9ba69c6

I'm running out of ideas

fb006af

interaction between matrix and build stages

0cdb7cb

opt-in to more frequent updates

91c0f92

sudo for everyone, with docker

f742cab

mr-c added 2 commits July 17, 2018 14:10

xenial everywhere

96bde16

add py3.7 to tox

fd9ffc6

mr-c approved these changes Jul 17, 2018

View reviewed changes

mr-c merged commit fd7d964 into common-workflow-language:master Jul 17, 2018

ThomasHickman deleted the relax_ruamel_yaml_dependancy branch July 17, 2018 11:41

ThomasHickman mentioned this pull request Jul 17, 2018

Relax ruamel.yaml dependancy cap and support python 3.7 common-workflow-language/cwltool#831

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Relax ruamel.yaml dependency and support python 3.7#189

Relax ruamel.yaml dependency and support python 3.7#189
mr-c merged 24 commits intocommon-workflow-language:masterfrom
wtsi-hgi:relax_ruamel_yaml_dependancy

ThomasHickman commented Jul 16, 2018

Uh oh!

mr-c left a comment

Uh oh!

psafont Jul 16, 2018

Uh oh!

tetron Jul 16, 2018

Uh oh!

ThomasHickman commented Jul 16, 2018 •

edited

Loading

Uh oh!

mr-c commented Jul 17, 2018 •

edited

Loading

Uh oh!

ThomasHickman commented Jul 17, 2018

Uh oh!

ThomasHickman commented Jul 17, 2018

Uh oh!

mr-c commented Jul 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ThomasHickman commented Jul 16, 2018

Uh oh!

mr-c left a comment

Choose a reason for hiding this comment

Uh oh!

psafont Jul 16, 2018

Choose a reason for hiding this comment

Uh oh!

tetron Jul 16, 2018

Choose a reason for hiding this comment

Uh oh!

ThomasHickman commented Jul 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mr-c commented Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThomasHickman commented Jul 17, 2018

Uh oh!

ThomasHickman commented Jul 17, 2018

Uh oh!

mr-c commented Jul 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ThomasHickman commented Jul 16, 2018 •

edited

Loading

mr-c commented Jul 17, 2018 •

edited

Loading