Merged
Conversation
0728f44 to
5eeb1d2
Compare
romac
approved these changes
Dec 11, 2024
2 tasks
melekes
added a commit
to cometbft/cometbft-rs
that referenced
this pull request
Jun 10, 2025
Port-of: cometbft/tendermint-rs#1479 Closes #101
melekes
added a commit
to cometbft/cometbft-rs
that referenced
this pull request
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export the
tendermint::abci::event::v0_37module so thatEventAttributes::V037variants can be constructed. This mirrorstendermint::abci::event::v0_34, which is part of the public API. It was not evident at first sight that any invariants were upheld forv0_37(requiring the module to be private) I figure not exporting it was an oversight.Closes #1476.
Updated all relevant documentation in docs(n/a)Updated all code comments where relevant(n/a)Wrote tests(n/a).changelog/