Merged
Conversation
Port-of: cometbft/tendermint-rs#1479 Closes #101
There was a problem hiding this comment.
Pull Request Overview
This PR exports the abci::event::v0_37 module to enable construction of EventAttribute::V037 variants.
- Makes the v0_37 module public
- Updates changelog to reflect this change
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cometbft/src/abci/event.rs | Changed module visibility of v0_37 to public |
| .changelog/unreleased/bug-fixes/101-export-v0_37-abci-events.md | Added changelog entry for exporting v0_37 events |
Comments suppressed due to low confidence (1)
cometbft/src/abci/event.rs:373
- [nitpick] Since v0_37 is now part of the public API, consider adding module-level documentation to clarify its purpose and usage.
pub mod v0_37 {
greg-szabo
approved these changes
Jun 12, 2025
greg-szabo
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port-of: cometbft/tendermint-rs#1479
Closes #101