ABCI 2.0: make sure we only include meaningful header data#98
Merged
sergio-mena merged 2 commits intofeature/abci++veffrom Jan 16, 2023
Merged
ABCI 2.0: make sure we only include meaningful header data#98sergio-mena merged 2 commits intofeature/abci++veffrom
sergio-mena merged 2 commits intofeature/abci++veffrom
Conversation
… passed-through to application (#8216) closes: #7950
jmalicevic
approved these changes
Jan 16, 2023
sergio-mena
added a commit
that referenced
this pull request
Mar 3, 2023
… passed-through to application (#8216) (#98) closes: #7950 Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
3 tasks
3 tasks
cometcrafter
pushed a commit
to graphprotocol/cometbft
that referenced
this pull request
Jun 25, 2024
…v0.37.4/pr-97 perf(p2p/connection): Lower wasted re-allocations in sendRoutine (bac… (backport cometbft#97)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97
In
v0.36.xwe decided to not expose the whole block header to the application. We did some due diligence to find out which fields where used by the SDK, ibc-go, and gaia; and made only those fields available via ABCI. See this comment for details on the due diligence.This PR is based on tendermint/tendermint#8216 to make sure that work is kept completely in the current implementation.
In the end, all code has been (manually) done in previous commits related to
FinalizeBlockand/or vote extension, so the resulting PR is pretty trivial. Still submitting separately for clearer documentation of this aspect.PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed