abci++: only include meaningful header fields in data passed-through to application by williambanfield · Pull Request #8216 · tendermint/tendermint

williambanfield · 2022-03-29T20:58:13Z

closes: #7950

sergio-mena

Thanks for this! Looking great!

cmwaters

The one piece of information that I think is missing that applications may want is to know who the proposer for the block was

sergio-mena · 2022-03-30T08:53:05Z

The one piece of information that I think is missing that applications may want is to know who the proposer for the block was

@cmwaters are you thinking of its possible use by slashing and/or distribution modules?

cmwaters · 2022-03-30T09:13:45Z

Yes in the past, the SDK have allowed the proposer to receive an additional reward. I think generally it makes sense because there's nothing else that could inform the application of the proposer elected without the application having to run the algorithm themselves

tychoish · 2022-03-30T13:21:59Z

proto/tendermint/abci/types.proto

+  int64                     height               = 2;
+  google.protobuf.Timestamp time                 = 3 [(gogoproto.nullable) = false, (gogoproto.stdtime) = true];
+  repeated bytes            txs                  = 4;
+  CommitInfo                decided_last_commit  = 5 [(gogoproto.nullable) = false];


should this flip with the previous line?

sergio-mena · 2022-03-30T15:26:30Z

Yes in the past, the SDK have allowed the proposer to receive an additional reward

I'm aware of that. That's what I'm concerned with, although I don't have hard proof today. We're having preliminary discussions in the Protocol Desgin team within Informal, but no results yet.

So, as there isn't any hard proof at the moment (about asymmetric rewards encouraging byzantine behavior), I'm OK with including this field. We can always deprecate it and/or discourage its use in the future.

cmwaters · 2022-03-30T15:29:50Z

Ref: https://github.com/cosmos/cosmos-sdk/blob/90f61870e69b7cc07ac8537949715638af62f386/x/distribution/abci.go#L36

williambanfield · 2022-03-30T18:20:32Z

Ref: https://github.com/cosmos/cosmos-sdk/blob/90f61870e69b7cc07ac8537949715638af62f386/x/distribution/abci.go#L36

Happy to add it as part of this pull request. I did a pass through the SDK and this appears to the main field missed. I also see the SDK make many references to the ChainID. @cmwaters do you know if the SDK stores the chain ID anywhere and doesn't rely strictly on getting it from the block header?

cc: @marbar3778 as well.

tac0turtle · 2022-03-31T15:15:13Z

Id prefer to keep the entire header being passed to the application in at least one phase since we don't know all the use cases an application may have for this.

Is there any benefit to not passing it, it doesn't seem like there is an added overhead to the message, In 99.9% cases the application and tendermint will run on the same machine so the over head is very very minimal.

The sdk doesn't have complex use cases for most things, all the modules are simple implementations, there are chains looking at doing more complex things that may need this data, but passing it each time may not be needed.

sergio-mena · 2022-03-31T15:57:47Z

Id prefer to keep the entire header being passed to the application in at least one phase since we don't know all the use cases an application may have for this.

Is there any benefit to not passing it, it doesn't seem like there is an added overhead to the message, In 99.9% cases the application and tendermint will run on the same machine so the over head is very very minimal.

The sdk doesn't have complex use cases for most things, all the modules are simple implementations, there are chains looking at doing more complex things that may need this data, but passing it each time may not be needed.

I'm not convinced that exposing the whole header to the App (with all the hashes, etc) is the cleanest API. Since this API is defined using protobufs, we can easily add any field that might be missing, without breaking backwards compatibility.

creachadair · 2022-03-31T16:40:30Z

The sdk doesn't have complex use cases for most things, all the modules are simple implementations, there are chains looking at doing more complex things that may need this data, but passing it each time may not be needed.

I'm not convinced that exposing the whole header to the App (with all the hashes, etc) is the cleanest API. Since this API is defined using protobufs, we can easily add any field that might be missing, without breaking backwards compatibility.

Adding to this: The concern about existing use is a very reasonable one. Because ABCI++ will require all applications to make changes, however, this is one of the rare cases where we can get meaningful feedback about what applications are actually doing.

If an app needs header data that we aren't exposing in ABCI++, I'd like them to come talk to us about it. Minimizing the header to start will allow us to have that conversation (and we could add more fields in a point release, it wouldn't require a major update).

tac0turtle · 2022-03-31T21:28:25Z

Either way works with me, I don't have the full scope of what people are doing, and the cosmos-sdk repo is not a good representation. The ibc team may have better insight here

williambanfield · 2022-03-31T22:58:06Z

Either way works with me, I don't have the full scope of what people are doing, and the cosmos-sdk repo is not a good representation. The ibc team may have better insight here

Thanks for the info marko we pinged the IBC-rs team to see if they have more info.

williambanfield · 2022-04-01T17:20:15Z

I spoke with @seantking and @sergio-mena spoke with @ancazamfir who both have much better understanding of IBC and the relevant code.

The IBC protocol currently does use an additional field of the block header that I was not aware of. It uses the NextValidatorsHash in the upgrade logic and currently relies on getting this from the ABCI calls. By the comment in that function, it appears that the field is used to ensure that the next block produced by the upgraded chain is signed by the correct set of validators. I'm not deeply familiar with the protocol, but it does seem that the same set of information could be queried from elsewhere. Currently, it could be queried from RPC on startup if the old blockstore is still accessible. Alternatively, it could be added to the RequestInitChain type so that applications starting up from a fork-upgrade can access the data.

At the moment, it appears that our options are to include the field within the RequestFinalizeBlock call so that IBC does not need to update, or remove it and require that IBC query the block data in the same way that Light clients do, via the RPC. If we include it in the Request, I'd suggest marking it as Experimental in some way so that we can signal that it may be subject to change and suggest that applications migrate the RPC.

From my perspective, many of these fields are deeply internal and will not, nor really should, be relied on by 99% of ABCI applications so we should make the best effort that we can make to keep them internal. Keeping them internal will more accurately reflect the longterm promises that Tendermint can make about the structure of the data in the block chain. Any piece of data we expose becomes a piece of data we'll need to maintain so we should, imo, bias towards removing whatever we can.

creachadair · 2022-04-01T17:58:47Z

The IBC protocol currently does use an additional field of the block header that I was not aware of. It uses the NextValidatorsHash in the upgrade logic and currently relies on getting this from the ABCI calls. By the comment in that function, it appears that the field is used to ensure that the next block produced by the upgraded chain is signed by the correct set of validators. I'm not deeply familiar with the protocol, but it does seem that the same set of information could be queried from elsewhere. Currently, it could be queried from RPC on startup if the old blockstore is still accessible. Alternatively, it could be added to the RequestInitChain type so that applications starting up from a fork-upgrade can access the data.

While I guess it would be "cleaner" to make the caller fetch this information from the store, I worry that this would be problematic during an upgrade: If the old node has been brought down, there is no one to send an RPC to, which suggests the updating node might have to read it out of the blockstore directly. If that's correct, it seems worse—I think we'd probably rather have an excess field in the ABCI message than pin IBC to knowledge of the database format.

If this really is the only "extra" field we'd have to add to the ABCI message, that seems it might be a reasonable tradeoff. I agree that we should avoid adding any we don't have a positive use for (at least as a starting position).

williambanfield · 2022-04-11T19:29:20Z

proto/tendermint/abci/types.proto

      [(gogoproto.nullable) = false, (gogoproto.jsontag) = "events,omitempty"];
  repeated ExecTxResult            tx_results              = 2;
-  repeated ValidatorUpdate         validator_updates       = 3;
+  repeated ValidatorUpdate         validator_updates       = 3 [(gogoproto.nullable) = false];


This now matches the .intermediate file. It appears that at some point these files skewed.

williambanfield · 2022-04-11T19:29:57Z

proto/tendermint/abci/types.proto

+  int64        height = 1;
+  uint32       index  = 2;
+  bytes        tx     = 3;
+  ExecTxResult result = 4 [(gogoproto.nullable) = false];


Updated to match the .intermediate file.

cmwaters

LGTM thanks!

…passed-through to application (#8216)

@cmwaters

…to App (#9219) * [cherrypicked] abci++: only include meaningful header fields in data passed-through to application (#8216) * make proto-gen * Fix kvstore tests * Small changes to abci protobufs taken from v0.36.x * make proto-gen (again) * [Partial cherrypick] Restore `Commit` to the ABCI++ spec, and other late modifications (backport #8796) (#8936) * Restore `Commit` to the ABCI++ spec, and other late modifications (#8796) * Added VoteExtensionsEnableHeight * Fix reference to `modified` * Removed old pseudo-code, now included in spec * Removed markdown warnings in abci++_basic_concepts_002_draft.md * Restored `Commit` in the Methods section * Addressed remaining markdown warnings * Revisited intro and basic concepts section * Extra pass at all spec sections to recover Commit, and other ABCI++ spec modifications * Fixed links * make proto-gen * Remove _primes_ from spec notation * Update proto/tendermint/abci/types.proto Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Update spec/abci++/abci++_tmint_expected_behavior_002_draft.md Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Addressed @cmwaters' comments * Addressed @angbrav's and @mpoke's comments on spec * make proto-gen * Fix MD anchor reference * Clarify throughout the spec when `ProcessProposal` and `VerifyVoteExtension` are called * Update spec/abci++/abci++_app_requirements_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_app_requirements_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_app_requirements_002_draft.md Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> * Update spec/abci++/abci++_methods_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_tmint_expected_behavior_002_draft.md Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> * Addresed comments * Renamed 'draft' files * Adatped links to new filenames * Fixed links and minor cosmetic changes * Renamed 'byzantine_validators' to 'misbehavior' in ABCI++ spec and protobufs * make proto-gen * Renamed 'byzantine_validators' to 'misbehavior' in the code * Fixed link * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Addressed @cason's comments * Clarified conditions for `ProcessProposal` call at proposer Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: Daniel <daniel.cason@usi.ch> (cherry picked from commit 331860c) * Fixed merge conflicts Co-authored-by: Sergio Mena <sergio@informal.systems> * make proto-gen (and again) * make build * fix UTs Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

@cmwaters

…to App (#9219) * [cherrypicked] abci++: only include meaningful header fields in data passed-through to application (#8216) * make proto-gen * Fix kvstore tests * Small changes to abci protobufs taken from v0.36.x * make proto-gen (again) * [Partial cherrypick] Restore `Commit` to the ABCI++ spec, and other late modifications (backport #8796) (#8936) * Restore `Commit` to the ABCI++ spec, and other late modifications (#8796) * Added VoteExtensionsEnableHeight * Fix reference to `modified` * Removed old pseudo-code, now included in spec * Removed markdown warnings in abci++_basic_concepts_002_draft.md * Restored `Commit` in the Methods section * Addressed remaining markdown warnings * Revisited intro and basic concepts section * Extra pass at all spec sections to recover Commit, and other ABCI++ spec modifications * Fixed links * make proto-gen * Remove _primes_ from spec notation * Update proto/tendermint/abci/types.proto Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Update spec/abci++/abci++_tmint_expected_behavior_002_draft.md Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Addressed @cmwaters' comments * Addressed @angbrav's and @mpoke's comments on spec * make proto-gen * Fix MD anchor reference * Clarify throughout the spec when `ProcessProposal` and `VerifyVoteExtension` are called * Update spec/abci++/abci++_app_requirements_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_app_requirements_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_app_requirements_002_draft.md Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> * Update spec/abci++/abci++_methods_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_tmint_expected_behavior_002_draft.md Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> * Addresed comments * Renamed 'draft' files * Adatped links to new filenames * Fixed links and minor cosmetic changes * Renamed 'byzantine_validators' to 'misbehavior' in ABCI++ spec and protobufs * make proto-gen * Renamed 'byzantine_validators' to 'misbehavior' in the code * Fixed link * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_basic_concepts.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Update spec/abci++/abci++_methods.md Co-authored-by: Daniel <daniel.cason@usi.ch> * Addressed @cason's comments * Clarified conditions for `ProcessProposal` call at proposer Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: Daniel <daniel.cason@usi.ch> (cherry picked from commit 331860c) * Fixed merge conflicts Co-authored-by: Sergio Mena <sergio@informal.systems> * make proto-gen (and again) * make build * fix UTs Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

… passed-through to application (tendermint#8216) (#98) closes: tendermint#7950 Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>

… passed-through to application (tendermint#8216) (#98) (tendermint#453) closes: tendermint#7950 Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>

abci++: only include meaningful fields in app passed-through data

686b7d3

williambanfield requested review from ancazamfir, cason, cmwaters, creachadair, ebuchman, jmalicevic, josef-widder, milosevic, sergio-mena, thanethomson and tychoish as code owners March 29, 2022 20:58

creachadair approved these changes Mar 29, 2022

View reviewed changes

sergio-mena approved these changes Mar 29, 2022

View reviewed changes

Merge branch 'master' into wb/issue-7950

35fa6da

cmwaters suggested changes Mar 30, 2022

View reviewed changes

tychoish approved these changes Mar 30, 2022

View reviewed changes

williambanfield added this to the v0.36 milestone Mar 30, 2022

williambanfield added 6 commits April 11, 2022 12:19

update prepare proposal docs

348076a

mechanical update of field names

9388bd6

doc updates

3bb5c4b

Merge remote-tracking branch 'origin' into wb/issue-7950

d7ae7f3

Merge remote-tracking branch 'origin/wb/issue-7950' into wb/issue-7950

694fb35

post-merge file fix ups

4be3ef8

williambanfield force-pushed the wb/issue-7950 branch from 3a43a6b to 4be3ef8 Compare April 11, 2022 19:27

williambanfield commented Apr 11, 2022

View reviewed changes

williambanfield added 3 commits April 11, 2022 15:33

re-add proposer

ce9bb04

re-add proposer

1cf9888

re-add proposer

5b948ba

cmwaters approved these changes Apr 11, 2022

View reviewed changes

Merge branch 'master' into wb/issue-7950

a0f1f4d

mergify bot merged commit 969690d into master Apr 11, 2022

mergify bot deleted the wb/issue-7950 branch April 11, 2022 20:27

This was referenced Aug 8, 2022

ABCI++ Prepare/Process Proposal #9053

Closed

abci: implement process proposal to spec #9122

Merged

sergio-mena mentioned this pull request Aug 10, 2022

Block data exposed to App #9211

Closed

sergio-mena pushed a commit that referenced this pull request Aug 10, 2022

[cherrypicked] abci++: only include meaningful header fields in data …

3efcf98

…passed-through to application (#8216)

sergio-mena mentioned this pull request Aug 10, 2022

PrepareProposal/ProcessProposal: Dealing with block data exposed to App #9219

Merged

3 tasks

sergio-mena mentioned this pull request Sep 8, 2022

ABCI++ vote extensions & FinalizeBlock #9396

Closed

17 tasks

sergio-mena mentioned this pull request Nov 3, 2022

abci: implement finalize block #9468

Merged

sergio-mena mentioned this pull request Dec 19, 2022

ABCI 2.0: Final adjustments #9916

Closed

13 tasks

sergio-mena mentioned this pull request Jan 12, 2023

ABCI 2.0: make sure we only include meaningful header data cometbft/cometbft#98

Merged

3 tasks

cason mentioned this pull request Apr 15, 2024

spec: fix the references for misbehavior cometbft/cometbft#2789

Merged

4 tasks

Conversation

williambanfield commented Mar 29, 2022

Uh oh!

sergio-mena left a comment

Choose a reason for hiding this comment

Uh oh!

cmwaters left a comment

Choose a reason for hiding this comment

Uh oh!

sergio-mena commented Mar 30, 2022

Uh oh!

cmwaters commented Mar 30, 2022

Uh oh!

tychoish Mar 30, 2022

Choose a reason for hiding this comment

Uh oh!

sergio-mena commented Mar 30, 2022

Uh oh!

cmwaters commented Mar 30, 2022

Uh oh!

williambanfield commented Mar 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tac0turtle commented Mar 31, 2022

Uh oh!

sergio-mena commented Mar 31, 2022

Uh oh!

creachadair commented Mar 31, 2022

Uh oh!

tac0turtle commented Mar 31, 2022

Uh oh!

williambanfield commented Mar 31, 2022

Uh oh!

williambanfield commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

creachadair commented Apr 1, 2022

Uh oh!

williambanfield Apr 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

williambanfield Apr 11, 2022

Choose a reason for hiding this comment

Uh oh!

cmwaters left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

williambanfield commented Mar 30, 2022 •

edited

Loading

williambanfield commented Apr 1, 2022 •

edited

Loading

williambanfield Apr 11, 2022 •

edited

Loading