fix(spec/abci): Added proper description of ExtendedVoteInfo and VoteInfo#4460
Merged
jmalicevic merged 13 commits intomainfrom Nov 13, 2024
Merged
fix(spec/abci): Added proper description of ExtendedVoteInfo and VoteInfo#4460jmalicevic merged 13 commits intomainfrom
ExtendedVoteInfo and VoteInfo#4460jmalicevic merged 13 commits intomainfrom
Conversation
Closed
3 tasks
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
cason
reviewed
Nov 11, 2024
cason
left a comment
There was a problem hiding this comment.
Thank you for this. Left a couple of comments and suggestions.
We should fix the VoteInfo description as well.
spec/abci/abci++_methods.md
Outdated
| * This information is extracted from CometBFT's data structures in the local process. | ||
| * `vote_extension` contains the sending validator's vote extension, which is signed by CometBFT. It can be empty | ||
| * `extension_signature` contains all the signatures that signed the vote. This way, when this is passed to the application, it can | ||
| verify the signatures that signed the vote. |
There was a problem hiding this comment.
Actually, this is not the point here. Comet has verified the signature, otherwise it would not appear here. We render it available in the case the application needs it for any different reason.
ExtendedVoteInfo ExtendedVoteInfo
Co-authored-by: Daniel <daniel.cason@informal.systems>
3 tasks
…4485) To be merged against #4460. Fixed some markdown tables as well. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments
cason
approved these changes
Nov 13, 2024
ExtendedVoteInfo ExtendedVoteInfo and VoteInfo
mergify bot
added a commit
that referenced
this pull request
Nov 13, 2024
…oteInfo` (#4460) Closes #4458 --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Daniel <daniel.cason@informal.systems> (cherry picked from commit 41d522a)
mergify bot
added a commit
that referenced
this pull request
Nov 13, 2024
…oteInfo` (#4460) Closes #4458 --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Daniel <daniel.cason@informal.systems> (cherry picked from commit 41d522a)
This was referenced Nov 13, 2024
Merged
jmalicevic
added a commit
that referenced
this pull request
Nov 13, 2024
…oteInfo` (backport #4460) (#4487) Closes #4458 --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4460 done by [Mergify](https://mergify.com). Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
jmalicevic
added a commit
that referenced
this pull request
Nov 13, 2024
…oteInfo` (backport #4460) (#4488) Closes #4458 --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4460 done by [Mergify](https://mergify.com). Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4458
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments