Skip to content

fix(spec/abci): VoteInfo description updated from proto definition#4485

Merged
jmalicevic merged 1 commit intojasmina/fix-abci-specfrom
cason/jasmina-fix-abci-spec
Nov 13, 2024
Merged

fix(spec/abci): VoteInfo description updated from proto definition#4485
jmalicevic merged 1 commit intojasmina/fix-abci-specfrom
cason/jasmina-fix-abci-spec

Conversation

@cason
Copy link

@cason cason commented Nov 13, 2024

To be merged against #4460.

Fixed some markdown tables as well.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@cason cason requested review from a team as code owners November 13, 2024 14:02
@cason cason changed the title spec/abci: fix VoteInfo description based on protos fix(spec/abci): VoteInfo description updated from proto definition Nov 13, 2024
Copy link
Collaborator

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmalicevic jmalicevic merged commit 3ea2bba into jasmina/fix-abci-spec Nov 13, 2024
@jmalicevic jmalicevic deleted the cason/jasmina-fix-abci-spec branch November 13, 2024 15:12
@jmalicevic jmalicevic added bug Something isn't working documentation Improvements or additions to documentation spec Specification-related labels Dec 3, 2024
@jmalicevic jmalicevic added this to the 2024-Q4 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation spec Specification-related

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants