Merged
Conversation
Because, in cometbft-db v0.13+, the iterator is being reused so we need to always copy key and value if we're storing them in a map or other in-memory structure. Closes #4295
andynog
approved these changes
Oct 23, 2024
Collaborator
andynog
left a comment
There was a problem hiding this comment.
The changes look good to me. I've performed some local testing with the kvstore and before I was only getting one event from tx_search using goleveldb backend, but now I get multiple evens as expected. So seems to be fixed.
But I there is a go vulnerability check that is failing in CI, I don't get it running make vulncheck on my local machine though.
3 tasks
Collaborator
Author
|
This patch was also verified by the Noble team ✅ |
Collaborator
Author
|
@mergify backport v0.37.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
added a commit
that referenced
this pull request
Oct 24, 2024
Because, in cometbft-db v0.13+, the iterator is being reused so we need to always copy key and value if we're storing them in a map or other in-memory structure. Closes #4295 <hr>This is an automatic backport of pull request #4321 done by [Mergify](https://mergify.com). --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
mergify bot
added a commit
that referenced
this pull request
Oct 24, 2024
Because, in cometbft-db v0.13+, the iterator is being reused so we need to always copy key and value if we're storing them in a map or other in-memory structure. Closes #4295 <hr>This is an automatic backport of pull request #4321 done by [Mergify](https://mergify.com). --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because, in cometbft-db v0.13+, the iterator is being reused so we need to always copy key and value if we're storing them in a map or other in-memory structure.
Closes #4295