Skip to content

fix(mempool): Fix mutex in Flush method#3725

Merged
hvanz merged 13 commits intomainfrom
hvanz/mempool-fix-flush-mutex-2443
Aug 20, 2024
Merged

fix(mempool): Fix mutex in Flush method#3725
hvanz merged 13 commits intomainfrom
hvanz/mempool-fix-flush-mutex-2443

Conversation

@hvanz
Copy link
Collaborator

@hvanz hvanz commented Aug 16, 2024

Fixes #2443

Note that Flush is only called from an (unsafe) RPC endpoint, so it can be called at any time.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@hvanz hvanz added bug Something isn't working mempool labels Aug 16, 2024
@hvanz hvanz self-assigned this Aug 16, 2024
@hvanz hvanz requested a review from a team as a code owner August 16, 2024 15:43
@hvanz hvanz requested a review from a team August 16, 2024 15:43
Copy link
Collaborator

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hvanz hvanz added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit fb3f52b Aug 20, 2024
@hvanz hvanz deleted the hvanz/mempool-fix-flush-mutex-2443 branch August 20, 2024 05:55
mergify bot added a commit that referenced this pull request Aug 20, 2024
Fixes #2443

Note that `Flush` is only called from an (unsafe) RPC endpoint, so it
can be called at any time.

---

#### PR checklist

- [ ] Tests written/updated
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit fb3f52b)
hvanz added a commit that referenced this pull request Aug 20, 2024
Fixes #2443

Note that `Flush` is only called from an (unsafe) RPC endpoint, so it
can be called at any time.

---

#### PR checklist

- [ ] Tests written/updated
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
<hr>This is an automatic backport of pull request #3725 done by
[Mergify](https://mergify.com).

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
@jmalicevic jmalicevic added this to the 2024-Q3 milestone Aug 27, 2024
aljo242 pushed a commit that referenced this pull request Sep 3, 2025
Fixes #2443

Note that `Flush` is only called from an (unsafe) RPC endpoint, so it
can be called at any time.

---

#### PR checklist

- [ ] Tests written/updated
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working mempool

Projects

No open projects
Status: Done

3 participants