mempool: CListMempool.Flush invokes a read-lock meanwhile it performs write/mutating operations; inadequately tested because there will be data races too

## Bug Report
Noticed in a code audit that this code is erroneously invoking a read-lock meanwhile it performs write/mutating operations

https://github.com/cometbft/cometbft/blob/4ce0277b35f31985bbf2c25d3806a184a4510010/mempool/clist_mempool.go#L221-L229

which also means that this mempool implementation is not properly tested because it clearly invokes mutating code here https://github.com/cometbft/cometbft/blob/4ce0277b35f31985bbf2c25d3806a184a4510010/mempool/clist_mempool.go#L136-L147

	func (mem *CListMempool) Flush() {
	mem.updateMtx.RLock()
	defer mem.updateMtx.RUnlock()

	mem.txsBytes.Store(0)
	mem.cache.Reset()

	mem.removeAllTxs()
	}

	func (mem *CListMempool) removeAllTxs() {
	for e := mem.txs.Front(); e != nil; e = e.Next() {
	mem.txs.Remove(e)
	e.DetachPrev()
	}

	mem.txsMap.Range(func(key, _ interface{}) bool {
	mem.txsMap.Delete(key)
	mem.invokeRemoveTxOnReactor(key.(types.TxKey))
	return true
	})
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mempool: CListMempool.Flush invokes a read-lock meanwhile it performs write/mutating operations; inadequately tested because there will be data races too #2443

Bug Report

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

mempool: CListMempool.Flush invokes a read-lock meanwhile it performs write/mutating operations; inadequately tested because there will be data races too #2443

Description

Bug Report

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions