Conversation
added 3 commits
July 22, 2024 18:46
…t correctly in the serialized JSON structs
cason
reviewed
Jul 23, 2024
cason
left a comment
There was a problem hiding this comment.
This is ready for review, in my opinion.
.changelog/unreleased/bug-fixes/3543-evidence-missing-json-tags.md
Outdated
Show resolved
Hide resolved
.changelog/unreleased/bug-fixes/3543-evidence-missing-json-tags.md
Outdated
Show resolved
Hide resolved
added 2 commits
July 23, 2024 09:32
cason
approved these changes
Jul 23, 2024
cason
left a comment
There was a problem hiding this comment.
Thanks.
We have to define to which release branches to backport this bug fix.
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
…htClientAttackEvidence` types (#3543) Closes #3528 ### Changes Added missing JSON tags to `DuplicateVoteEvidence` and `LightClientAttackEvidence` types. --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit fbca5ac)
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
…htClientAttackEvidence` types (#3543) Closes #3528 ### Changes Added missing JSON tags to `DuplicateVoteEvidence` and `LightClientAttackEvidence` types. --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit fbca5ac) # Conflicts: # .changelog/v0.38.3/bug-fixes/3528-evidence-missing-json-tags.md # types/evidence_test.go
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
…htClientAttackEvidence` types (#3543) Closes #3528 ### Changes Added missing JSON tags to `DuplicateVoteEvidence` and `LightClientAttackEvidence` types. --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit fbca5ac) # Conflicts: # types/evidence_test.go
3 tasks
3 tasks
alesforz
added a commit
that referenced
this pull request
Jul 23, 2024
…htClientAttackEvidence` types (backport #3543) (#3548) Closes #3528 ### Changes Added missing JSON tags to `DuplicateVoteEvidence` and `LightClientAttackEvidence` types. --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3543 done by [Mergify](https://mergify.com). Co-authored-by: Alessandro Sforzin <alesforz@gmail.com>
alesforz
added a commit
that referenced
this pull request
Jul 24, 2024
…htClientAttackEvidence` types (backport #3543) (#3549) Closes #3528 ### Changes Added missing JSON tags to `DuplicateVoteEvidence` and `LightClientAttackEvidence` types. --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3543 done by [Mergify](https://mergify.com). --------- Co-authored-by: Alessandro Sforzin <alesforz@gmail.com> Co-authored-by: Alessandro <alessandro@informal.systems>
alesforz
added a commit
that referenced
this pull request
Jul 24, 2024
…htClientAttackEvidence` types (backport #3543) (#3550) Closes #3528 ### Changes Added missing JSON tags to `DuplicateVoteEvidence` and `LightClientAttackEvidence` types. --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3543 done by [Mergify](https://mergify.com). --------- Co-authored-by: Alessandro Sforzin <alesforz@gmail.com> Co-authored-by: Alessandro <alessandro@informal.systems>
This was referenced Aug 12, 2024
1 task
1 task
alesforz
pushed a commit
that referenced
this pull request
Aug 15, 2024
Given the discussion in #3528, we are reverting the changes made by #3543 in `v0.38.x` (backported with #3549). Additionally, we are removing the changes made in #3543 from the CHANGELOG. --- #### PR checklist ~- [ ] Tests written/updated~ ~- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ ~- [] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
alesforz
pushed a commit
that referenced
this pull request
Aug 15, 2024
Given the discussion in #3528, we are reverting the changes made by #3543 in `v0.37.x` (backported with #3550). Additionally, we are removing the changes made in #3543 from the CHANGELOG. --- #### PR checklist ~- [ ] Tests written/updated~ ~- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ ~- [] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
5 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3528
Changes
Added missing JSON tags to
DuplicateVoteEvidenceandLightClientAttackEvidencetypes.PR checklist
.changelog(we use unclog to manage our changelog)- [ ] Updated relevant documentation (docs/orspec/) and code comments