revert(types): Revert #3543 (backport #3549)#3705
Merged
Conversation
sergio-mena
reviewed
Aug 14, 2024
sergio-mena
approved these changes
Aug 14, 2024
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Just one minor comment
…se the CHANGELOG will update automatically with the next point release. This reverts commit ece7c8e.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the discussion in #3528, we are reverting the changes made by #3543 in
v0.38.x(backported with #3549).Additionally, we are removing the changes made in #3543 from the CHANGELOG.
PR checklist
- [ ] Tests written/updated- [ ] Changelog entry added in.changelog(we use unclog to manage our changelog)- [] Updated relevant documentation (docs/orspec/) and code comments