Skip to content

fix(ci): run make all error 'No rule to make target 'check''#3530

Merged
melekes merged 2 commits intocometbft:mainfrom
Halimao:fix/make-all
Jul 26, 2024
Merged

fix(ci): run make all error 'No rule to make target 'check''#3530
melekes merged 2 commits intocometbft:mainfrom
Halimao:fix/make-all

Conversation

@Halimao
Copy link
Contributor

@Halimao Halimao commented Jul 22, 2024

Running make all would cause an error: make: *** No rule to make target 'check', needed by 'all'. Stop.

The check target has already removed, let's delete it

@Halimao Halimao requested a review from a team as a code owner July 22, 2024 03:23
@Halimao Halimao requested a review from a team July 22, 2024 03:23
@Halimao Halimao changed the title fix: run make all error 'No rule to make target 'check'' fix(ci): run make all error 'No rule to make target 'check'' Jul 22, 2024
@cason
Copy link

cason commented Jul 22, 2024

The check entry was removed by tendermint/tendermint#3949.

It was replaced by a tools.mk, later removed by tendermint/tendermint#6102.

Copy link

@cason cason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Collaborator

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melekes melekes added this pull request to the merge queue Jul 26, 2024
@melekes melekes added backport-to-v0.37.x backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x labels Jul 26, 2024
Merged via the queue into cometbft:main with commit 5744823 Jul 26, 2024
mergify bot pushed a commit that referenced this pull request Jul 26, 2024
Running `make all` would cause an error: `make: *** No rule to make
target 'check', needed by 'all'. Stop.`

The `check` target has already removed, let's delete it

(cherry picked from commit 5744823)
mergify bot pushed a commit that referenced this pull request Jul 26, 2024
Running `make all` would cause an error: `make: *** No rule to make
target 'check', needed by 'all'. Stop.`

The `check` target has already removed, let's delete it

(cherry picked from commit 5744823)
mergify bot pushed a commit that referenced this pull request Jul 26, 2024
Running `make all` would cause an error: `make: *** No rule to make
target 'check', needed by 'all'. Stop.`

The `check` target has already removed, let's delete it

(cherry picked from commit 5744823)

# Conflicts:
#	Makefile
melekes pushed a commit that referenced this pull request Jul 26, 2024
…ort #3530) (#3559)

Running `make all` would cause an error: `make: *** No rule to make
target 'check', needed by 'all'. Stop.`

The `check` target has already removed, let's delete it<hr>This is an
automatic backport of pull request #3530 done by
[Mergify](https://mergify.com).

Co-authored-by: Halimao <1065621723@qq.com>
melekes pushed a commit that referenced this pull request Jul 26, 2024
…ort #3530) (#3560)

Running `make all` would cause an error: `make: *** No rule to make
target 'check', needed by 'all'. Stop.`

The `check` target has already removed, let's delete it<hr>This is an
automatic backport of pull request #3530 done by
[Mergify](https://mergify.com).

Co-authored-by: Halimao <1065621723@qq.com>
melekes added a commit that referenced this pull request Jul 26, 2024
…ort #3530) (#3561)

Running `make all` would cause an error: `make: *** No rule to make
target 'check', needed by 'all'. Stop.`

The `check` target has already removed, let's delete it<hr>This is an
automatic backport of pull request #3530 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Halimao <1065621723@qq.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants