Skip to content

Update Makefile#3949

Merged
tac0turtle merged 35 commits intomasterfrom
updateconfig
Sep 13, 2019
Merged

Update Makefile#3949
tac0turtle merged 35 commits intomasterfrom
updateconfig

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Sep 4, 2019

  • these two files were taken from the sdk with adjustments for usage in TM

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@tac0turtle
Update makefile
57523ce 
- these two files were taken from the sdk with adjustments for usage in TM

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle self-assigned this Sep 5, 2019
@tac0turtle tac0turtle requested a review from mircea-c September 5, 2019 15:30
@tac0turtle
Copy link
Contributor Author

tac0turtle commented Sep 6, 2019

@jackzampolin can you configuration version 2.1 requires the "Enable Pipelines" project setting. Enable pipelines under Project Settings -> Advanced Settings. In order to retrigger pipelines, you must push a new commit.

@tac0turtle tac0turtle changed the title Update makefile Update Makefile Sep 6, 2019
@mircea-c
Copy link

mircea-c commented Sep 7, 2019

@marbar3778 I've enabled pipelines on the project

@tac0turtle
Copy link
Contributor Author

tac0turtle commented Sep 7, 2019 •
edited
Loading

Thank you, could you enable ci cancellation when you push before the previous one is over as well? Thank you!! Thank you thank you

@mircea-c
Copy link

mircea-c commented Sep 7, 2019

Already did 😄

@mircea-c mircea-c self-assigned this Sep 7, 2019
@tac0turtle tac0turtle force-pushed the updateconfig branch 2 times, most recently from 7e7da2b to 2d1d3cb Compare September 13, 2019 10:46
@tac0turtle tac0turtle marked this pull request as ready for review September 13, 2019 11:00
@codecov-io
Copy link

codecov-io commented Sep 13, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7e0b64e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3949   +/-   ##
=========================================
  Coverage          ?   66.86%           
=========================================
  Files             ?      219           
  Lines             ?    18481           
  Branches          ?        0           
=========================================
  Hits              ?    12358           
  Misses            ?     5198           
  Partials          ?      925

melekes
melekes approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☯️

@tac0turtle tac0turtle merged commit 21d46de into master Sep 13, 2019
@tac0turtle tac0turtle deleted the updateconfig branch September 13, 2019 16:52
@tac0turtle tac0turtle mentioned this pull request Sep 23, 2019
Merged
5 tasks
@adlerjohn adlerjohn mentioned this pull request May 14, 2023
Closed
@cason cason mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mircea-c mircea-c Awaiting requested review from mircea-c

@ebuchman ebuchman Awaiting requested review from ebuchman

@xla xla Awaiting requested review from xla

1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mircea-c mircea-c

@tac0turtle tac0turtle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tac0turtle @mircea-c @codecov-io @melekes