fix: invalid txs_results returned for legacy ABCI responses (backport #3031)#3435
fix: invalid txs_results returned for legacy ABCI responses (backport #3031)#3435
txs_results returned for legacy ABCI responses (backport #3031)#3435Conversation
close: #3002 This PR fixes the issue reported above. This is not a storage issue in particular, the results are still in storage after an upgrade, but not returned properly by the RPC endpoint. The fix is to make the `/block_results` endpoint in `v0.38` to return properly a legacy ABCI response created with `v0.37`. Once this fix is merged on `v0.38` and a patch release is cut, any node on `v0.38` (e.g. an archive node) that applies the patch release, should have the results returned properly by the RPC `/block_results` endpoint. --- #### PR checklist - [X] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Daniel <daniel.cason@informal.systems> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Daniel Wedul <github@wedul.com> (cherry picked from commit db6b608) # Conflicts: # state/errors.go # state/state_test.go # state/store.go # state/store_test.go
|
Cherry-pick of db6b608 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
there are many conflicts in this backport, will manually take care of it |
|
Comments for the reviewers of this backport. I had to manually go through and implement some of the backport changes to adapt them to There are some changes from the original PR that needed some "adaptation"
|
…tbft into mergify/bp/v0.38.x/pr-3031
sergio-mena
left a comment
There was a problem hiding this comment.
Went through diff-of-diffs. All discrepancies I saw are explained by this. So LGTM
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
close: #3002
This PR fixes the issue reported above.
This is not a storage issue in particular, the results are still in storage after an upgrade, but not returned properly by the RPC endpoint. The fix is to make the
/block_resultsendpoint inv0.38to return properly a legacy ABCI response created withv0.37.Once this fix is merged on
v0.38and a patch release is cut, any node onv0.38(e.g. an archive node) that applies the patch release, should have the results returned properly by the RPC/block_resultsendpoint.PR checklist
.changelog(we use unclog to manage our changelog)Updated relevant documentation (docs/orspec/) and code commentsThis is an automatic backport of pull request #3031 done by [Mergify](https://mergify.com).