fix: invalid txs_results returned for legacy ABCI responses#3031
Merged
fix: invalid txs_results returned for legacy ABCI responses#3031
txs_results returned for legacy ABCI responses#3031Conversation
sergio-mena
reviewed
May 8, 2024
sergio-mena
reviewed
May 8, 2024
sergio-mena
reviewed
May 8, 2024
Co-authored-by: Sergio Mena <sergio@informal.systems>
Collaborator
Author
|
I am working on some additional tests to ensure the logic holds and it makes sense |
cason
reviewed
May 10, 2024
cason
left a comment
There was a problem hiding this comment.
No reserve against this change.
I would move the added test unit elsewhere thought.
sergio-mena
reviewed
Jul 5, 2024
sergio-mena
reviewed
Jul 5, 2024
sergio-mena
reviewed
Jul 5, 2024
sergio-mena
reviewed
Jul 5, 2024
sergio-mena
reviewed
Jul 5, 2024
sergio-mena
reviewed
Jul 5, 2024
sergio-mena
reviewed
Jul 5, 2024
sergio-mena
reviewed
Jul 5, 2024
Co-authored-by: Sergio Mena <sergio@informal.systems>
sergio-mena
approved these changes
Jul 5, 2024
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Thanks a lot for this!
mergify bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
close: #3002 This PR fixes the issue reported above. This is not a storage issue in particular, the results are still in storage after an upgrade, but not returned properly by the RPC endpoint. The fix is to make the `/block_results` endpoint in `v0.38` to return properly a legacy ABCI response created with `v0.37`. Once this fix is merged on `v0.38` and a patch release is cut, any node on `v0.38` (e.g. an archive node) that applies the patch release, should have the results returned properly by the RPC `/block_results` endpoint. --- #### PR checklist - [X] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Daniel <daniel.cason@informal.systems> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Daniel Wedul <github@wedul.com> (cherry picked from commit db6b608)
mergify bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
close: #3002 This PR fixes the issue reported above. This is not a storage issue in particular, the results are still in storage after an upgrade, but not returned properly by the RPC endpoint. The fix is to make the `/block_results` endpoint in `v0.38` to return properly a legacy ABCI response created with `v0.37`. Once this fix is merged on `v0.38` and a patch release is cut, any node on `v0.38` (e.g. an archive node) that applies the patch release, should have the results returned properly by the RPC `/block_results` endpoint. --- #### PR checklist - [X] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Daniel <daniel.cason@informal.systems> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Daniel Wedul <github@wedul.com> (cherry picked from commit db6b608) # Conflicts: # state/errors.go # state/state_test.go # state/store.go # state/store_test.go
This was referenced Jul 5, 2024
andynog
added a commit
that referenced
this pull request
Jul 5, 2024
#3031) (#3434) close: #3002 This PR fixes the issue reported above. This is not a storage issue in particular, the results are still in storage after an upgrade, but not returned properly by the RPC endpoint. The fix is to make the `/block_results` endpoint in `v0.38` to return properly a legacy ABCI response created with `v0.37`. Once this fix is merged on `v0.38` and a patch release is cut, any node on `v0.38` (e.g. an archive node) that applies the patch release, should have the results returned properly by the RPC `/block_results` endpoint. --- #### PR checklist - [X] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3031 done by [Mergify](https://mergify.com). --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev>
andynog
added a commit
that referenced
this pull request
Jul 9, 2024
#3031) (#3435) close: #3002 This PR fixes the issue reported above. This is not a storage issue in particular, the results are still in storage after an upgrade, but not returned properly by the RPC endpoint. The fix is to make the `/block_results` endpoint in `v0.38` to return properly a legacy ABCI response created with `v0.37`. Once this fix is merged on `v0.38` and a patch release is cut, any node on `v0.38` (e.g. an archive node) that applies the patch release, should have the results returned properly by the RPC `/block_results` endpoint. --- #### PR checklist - [X] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3031 done by [Mergify](https://mergify.com). --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Collaborator
Author
|
Hi @mbreithecker, @mmsqe, @johnletey, @jhernandezb and @SpicyLemon This fixed has been back ported to Thanks again, Andy. |
|
Thank you very much! |
10 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #3002
This PR fixes the issue reported above.
This is not a storage issue in particular, the results are still in storage after an upgrade, but not returned properly by the RPC endpoint. The fix is to make the
/block_resultsendpoint inv0.38to return properly a legacy ABCI response created withv0.37.Once this fix is merged on
v0.38and a patch release is cut, any node onv0.38(e.g. an archive node) that applies the patch release, should have the results returned properly by the RPC/block_resultsendpoint.PR checklist
.changelog(we use unclog to manage our changelog)Updated relevant documentation (docs/orspec/) and code comments