refactor(mempool)!: remove PreUpdate from Mempool interface and move its logic to Lock#3361
Merged
refactor(mempool)!: remove PreUpdate from Mempool interface and move its logic to Lock#3361
Conversation
sergio-mena
reviewed
Jun 28, 2024
| // Safe for concurrent use by multiple goroutines. | ||
| func (mem *CListMempool) Lock() { | ||
| if mem.recheck.setRecheckFull() { | ||
| mem.logger.Debug("the state of recheckFull has flipped") |
Collaborator
There was a problem hiding this comment.
I think this message is not very useful if it doesn't say from X to Y, as we need to trace back all occurrences of this message for a node to find out if it is now full, or no longer full.
I think this message would be better inside recheck.setRecheckFull where it can provide this info.
In any case, I don't know if it should be done here, or in a different PR from main, and then backported all the way down.
Collaborator
Author
There was a problem hiding this comment.
Agree. I will do it from main in a different PR.
Collaborator
Author
|
Just realised the changelog file is in the wrong directory. It should be |
4 tasks
hvanz
added a commit
that referenced
this pull request
Jun 28, 2024
…its logic to Lock (#3363) Complements #3361 This PR partially reverts the backport of #3314 into the recently released v0.37.7. With this change the Mempool interface is the same as in previous versions. The reason is that we do not want to break the public API. We still keep in the code the feature that #3314 introduced by moving it inside the existing Lock method. We also keep the RecheckFull bool field that we added to ErrMempoolIsFull. <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially reverts the backport of #3314 into the recently released
v0.38.8(andv0.37.7). With this change theMempoolinterface is the same as in previous versions.The reason is that we do not want to break the public API. We still keep in the code the feature that #3314 introduced by moving it inside the existing
Lockmethod. We also keep theRecheckFull boolfield that we added toErrMempoolIsFull.#3363 does the same for
v0.37.x.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments