Conversation
4 tasks
Collaborator
|
Checking diff-of-diffs, I see this comment, added to // Before acquiring the lock, it signals the mempool that a new update is coming.
// If the mempool is still rechecking at this point, it should be considered full. |
sergio-mena
approved these changes
Jun 28, 2024
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Other than the comment about the missing text on Lock(), LGTM 👍
Collaborator
Author
|
Thanks, I added the missing comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complements #3361
This PR partially reverts the backport of #3314 into the recently released v0.37.7. With this change the Mempool interface is the same as in previous versions.
The reason is that we do not want to break the public API. We still keep in the code the feature that #3314 introduced by moving it inside the existing Lock method. We also keep the RecheckFull bool field that we added to ErrMempoolIsFull.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments