perf(consensus): Make one peer state mutex call in AddVote#3156
Merged
perf(consensus): Make one peer state mutex call in AddVote#3156
Conversation
Contributor
Author
|
Ah correction this is in v0.37.x, and does cause some very slight overhead. |
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 31, 2024
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
Jun 3, 2024
…3156) Closes cometbft#3155 --- - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
Jun 3, 2024
perf(consensus): Make one peer state mutex call in AddVote (cometbft#3156)
mergify bot
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
Jun 3, 2024
…3156) Closes cometbft#3155 --- - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 3cdc621)
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
Jun 3, 2024
…pr-91 perf(consensus): Make one peer state mutex call in AddVote (cometbft#3156) (backport #91)
Collaborator
|
@mergify backport v1.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Closes #3155 --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 9d7c968) # Conflicts: # .changelog/unreleased/improvements/3156-make-addvote-only-take-one-ps-mtx.md
4 tasks
melekes
added a commit
that referenced
this pull request
Jul 10, 2024
…3156) (#3473) Closes #3155 --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3156 done by [Mergify](https://mergify.com). --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
mattac21
pushed a commit
that referenced
this pull request
Sep 9, 2025
Closes #3155 --- - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
mattac21
pushed a commit
that referenced
this pull request
Sep 10, 2025
Closes #3155 --- - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3155
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments