-
Notifications
You must be signed in to change notification settings - Fork 780
Closed
osmosis-labs/cometbft
#91Labels
enhancementNew feature or requestNew feature or request
Milestone
Description
Feature Request
Summary
There was a regression at some point, and now adding a vote makes 3 mutex locks and unlocks to peerstate: https://github.com/cometbft/cometbft/blob/v0.37.6/consensus/reactor.go#L348-L350
We should just make one method, that takes a lock once, and then does all the relevant operations. I don't have system impact benchmarks, as this 3 mutex-taking is not in v0.37.x
Proposal
Make one method that just takes the peerstate lock once and does all 3 internal functions
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request