Merged
Conversation
sergio-mena
reviewed
May 1, 2024
| ## Options | ||
| Some of the parameters can be overridden by command-line flags. | ||
|
|
||
| The default configuration file created by `cometbft init` has all |
Collaborator
There was a problem hiding this comment.
Did you compare the text here with the new one in the CometBFT Configuration Manual? Is there anything in this text worth including there? Are the hunks toward the end of the PR doing this?
sergio-mena
reviewed
May 1, 2024
| Recovering nodes that "forget" the actions taken before crashing are faulty | ||
| nodes that are likely to present Byzantine behavior (e.g., double signing). | ||
|
|
||
| ## Consensus timeouts |
Collaborator
There was a problem hiding this comment.
This document is structured to contain the same sections as the config.toml. So by adding this section, we are splitting the consensus section, which no longer reflects the config.toml structure.
I suggest you remove this section marker, and move the sentence starting with "For a more detailed explanation" to each of the timeout fields.
sergio-mena
reviewed
May 1, 2024
Comment on lines
+1740
to
+1741
|
|
||
|
|
sergio-mena
reviewed
May 1, 2024
| |:--------------------|:--------------------------| | ||
| | **Possible values** | Prometheus namespace name | | ||
|
|
||
| ## Consensus timeouts explained |
Collaborator
There was a problem hiding this comment.
Suggested change
| ## Consensus timeouts explained | |
| # Consensus timeouts explained |
sergio-mena
approved these changes
May 1, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2024
closes #2769 merging configuration documents --- #### PR checklist - [ ] Tests written/updated - [X] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [X] Updated relevant documentation (`docs/` or `spec/`) and code comments - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 88c527b) # Conflicts: # docs/explanation/core/configuration.md
4 tasks
andynog
pushed a commit
that referenced
this pull request
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2769
merging configuration documents
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments