fix(rpc): Make websocket's log on success be in Debug, not info#2788
Merged
andynog merged 2 commits intocometbft:mainfrom Apr 11, 2024
Merged
fix(rpc): Make websocket's log on success be in Debug, not info#2788andynog merged 2 commits intocometbft:mainfrom
andynog merged 2 commits intocometbft:mainfrom
Conversation
This log is pure noise in our current setup for all RPC's. I moved to Debug, but should be deleted imo. This logging of requests/responses should come at a higher proxy level IMO, or have the request + response written elsewhere asynchronously.
andynog
approved these changes
Apr 11, 2024
Collaborator
andynog
left a comment
There was a problem hiding this comment.
lgtm. I think this makes sense to move to debug. Thanks for doing that.
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
This log is extreme noise in our current setup for all RPC's. I moved to Debug, but should be deleted imo. This logging of requests/responses should come at a higher proxy level IMO, or have the request + response written elsewhere asynchronously. <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 313557a)
4 tasks
melekes
pushed a commit
that referenced
this pull request
Apr 12, 2024
…port #2788) (#2790) This log is extreme noise in our current setup for all RPC's. I moved to Debug, but should be deleted imo. This logging of requests/responses should come at a higher proxy level IMO, or have the request + response written elsewhere asynchronously. --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2788 done by [Mergify](https://mergify.com). Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
czarcas7ic
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
Apr 15, 2024
…tbft#2788) This log is extreme noise in our current setup for all RPC's. I moved to Debug, but should be deleted imo. This logging of requests/responses should come at a higher proxy level IMO, or have the request + response written elsewhere asynchronously. <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
czarcas7ic
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
Apr 15, 2024
…g-noise fix(rpc): Make websocket's log on success be in Debug, not info (cometbft#2788)
czarcas7ic
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
Apr 15, 2024
…g-noise fix(rpc): Make websocket's log on success be in Debug, not info (cometbft#2788)
czarcas7ic
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 10, 2024
…g-noise fix(rpc): Make websocket's log on success be in Debug, not info (cometbft#2788)
PaddyMc
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
Aug 19, 2024
…g-noise fix(rpc): Make websocket's log on success be in Debug, not info (cometbft#2788)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This log is extreme noise in our current setup for all RPC's. I moved to Debug, but should be deleted imo.
This logging of requests/responses should come at a higher proxy level IMO, or have the request + response written elsewhere asynchronously.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments