Skip to content

fix(rpc): Make websocket's log on success be in Debug, not info (backport #2788)#2790

Merged
melekes merged 1 commit intov1.xfrom
mergify/bp/v1.x/pr-2788
Apr 12, 2024
Merged

fix(rpc): Make websocket's log on success be in Debug, not info (backport #2788)#2790
melekes merged 1 commit intov1.xfrom
mergify/bp/v1.x/pr-2788

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 11, 2024

This log is extreme noise in our current setup for all RPC's. I moved to Debug, but should be deleted imo.

This logging of requests/responses should come at a higher proxy level IMO, or have the request + response written elsewhere asynchronously.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

This is an automatic backport of pull request #2788 done by [Mergify](https://mergify.com).

This log is extreme noise in our current setup for all RPC's. I moved to
Debug, but should be deleted imo.

This logging of requests/responses should come at a higher proxy level
IMO, or have the request + response written elsewhere asynchronously.

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

(cherry picked from commit 313557a)
@mergify mergify bot requested a review from a team as a code owner April 11, 2024 19:32
@mergify mergify bot requested a review from a team April 11, 2024 19:32
@andynog andynog self-assigned this Apr 11, 2024
@andynog andynog added rpc P:operator-experience Priority: Improve experience for operators labels Apr 11, 2024
Copy link
Collaborator

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@melekes melekes merged commit 1edeaa2 into v1.x Apr 12, 2024
@melekes melekes deleted the mergify/bp/v1.x/pr-2788 branch April 12, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P:operator-experience Priority: Improve experience for operators rpc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants