Remove genesis persistence in state db#1017
Merged
sergio-mena merged 7 commits intocometbft:mainfrom Aug 30, 2023
Merged
Conversation
This was referenced Jun 23, 2023
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
mzabaluev
reviewed
Jul 4, 2023
mzabaluev
reviewed
Jul 4, 2023
Contributor
mzabaluev
left a comment
There was a problem hiding this comment.
Good quality code.
One concern voiced about this change is, we'd like to keep a hash of the genesis doc in the store for a sanity check.
mzabaluev
reviewed
Jul 4, 2023
Collaborator
|
Hey @drklee3 , thanks a lot for doing this. As @mzabaluev above said there are a few more options we are considering adding to this solution (like the hash of the doc in the store etc.) , its impact on the retrieval of the genesis doc via RPC and whether it can be improved when we have a solution for storing the file like this. We will explore them and build on the solution this quarter though : see #1037 . |
|
We need that fix to be able to import large (~10GB) genesis.json is kava or cronos fork for GenesisL1 blockchain. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Collaborator
|
Re-opening this because it is waiting for us to take a look at it once ADR-101 PRs are merged. |
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 6, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 14, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 14, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Feb 14, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Jul 7, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 backports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Jul 14, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 ports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian@users.noreply.github.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Jul 14, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 ports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian@users.noreply.github.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Jul 14, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 ports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian@users.noreply.github.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Jul 14, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 ports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian@users.noreply.github.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Jul 14, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 ports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian@users.noreply.github.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Jul 14, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 ports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian@users.noreply.github.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Oct 20, 2025
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 ports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian@users.noreply.github.com>
troian
added a commit
to akash-network/cometbft
that referenced
this pull request
Jan 23, 2026
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (panic: snappy: decoded block is too large). refs akash-network/support#280 ports: - cometbft#1017 - cometbft#1293 Signed-off-by: Artur Troian <troian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids saving the genesisDoc to database. When using goleveldb and ~4GiB+ genesis files, it causes a panic during snappy encoding (
panic: snappy: decoded block is too large). We run into this with a large Ethermint state in our mainnet exports.The main file to review is
node/setup.go, with changes mostly from tendermint/tendermint#6554Contributes to #1037
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments