Skip to content

node/tests: clean up use of genesis doc and surrounding tests#6554

Merged
cmwaters merged 3 commits intomasterfrom
callum/loading-genesis
Jun 8, 2021
Merged

node/tests: clean up use of genesis doc and surrounding tests#6554
cmwaters merged 3 commits intomasterfrom
callum/loading-genesis

Conversation

@cmwaters
Copy link
Contributor

@cmwaters cmwaters commented Jun 8, 2021

Closes: #6071

  • Don't persist genesis to the state store (rather just genesis state if it's not there)
  • Clean up a bunch of tests that don't need to use stores

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #6554 (4d88fac) into master (6f6ac5c) will decrease coverage by 0.03%.
The diff coverage is 47.05%.

@@            Coverage Diff             @@
##           master    #6554      +/-   ##
==========================================
- Coverage   61.06%   61.02%   -0.04%     
==========================================
  Files         295      295              
  Lines       27870    27855      -15     
==========================================
- Hits        17018    16998      -20     
- Misses       9132     9143      +11     
+ Partials     1720     1714       -6     
Impacted Files Coverage Δ
state/store.go 53.09% <ø> (-3.64%) ⬇️
node/node.go 51.85% <47.05%> (+0.28%) ⬆️
internal/statesync/block_queue.go 93.45% <0.00%> (-2.81%) ⬇️
internal/mempool/v0/reactor.go 72.41% <0.00%> (-2.76%) ⬇️
internal/blockchain/v0/pool.go 77.56% <0.00%> (-2.29%) ⬇️
internal/consensus/reactor.go 66.97% <0.00%> (-1.86%) ⬇️
internal/evidence/reactor.go 73.45% <0.00%> (-1.77%) ⬇️
state/state.go 84.47% <0.00%> (-0.63%) ⬇️
internal/consensus/state.go 66.60% <0.00%> (-0.28%) ⬇️
... and 9 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

state: streamline initialising of state

2 participants