perform environment calculation in Python#209
Merged
dirk-thomas merged 5 commits intomasterfrom Aug 26, 2019
Merged
Conversation
This was referenced Aug 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 77.85% 77.42% -0.44%
==========================================
Files 53 54 +1
Lines 3071 3109 +38
Branches 512 512
==========================================
+ Hits 2391 2407 +16
- Misses 652 675 +23
+ Partials 28 27 -1
Continue to review full report at Codecov.
|
adfd058 to
b33a08d
Compare
jacobperron
reviewed
Aug 26, 2019
Contributor
jacobperron
left a comment
There was a problem hiding this comment.
A few minor comments.
jacobperron
approved these changes
Aug 26, 2019
…y which uses the information from .dsv files
cb53896 to
8fc78e3
Compare
This was referenced Aug 26, 2019
Merged
seanyen
added a commit
to seanyen/colcon-core
that referenced
this pull request
Sep 6, 2019
It seems to be a regression after colcon#209, where it removed enabledelayedexpansion but forget to change the delay expansion usage back.
dirk-thomas
pushed a commit
that referenced
this pull request
Sep 6, 2019
It seems to be a regression after #209, where it removed enabledelayedexpansion but forget to change the delay expansion usage back.
jacobperron
added a commit
to jacobperron/ament_java
that referenced
this pull request
Oct 17, 2019
For more information about the introduction of .dsv files, see - colcon/colcon-core#209 - ament/ament_package#89 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.dsvfiles describing the intended environment change in a machine readable form (similar to generate .dsv files beside known environment hooks ament/ament_cmake#187).prefix_util.pyintoprefix_util.py.embefore changing its content.prefix_util.pymodule. The module will utilize the information from.dsvfiles to compute the desired environment changes within Python.shshell extension to use the.dsvfilesOther shell extensions still need to be updated...
Related to ros2/ros2#764.